Commit Graph

5 Commits

Author SHA1 Message Date
alexei.dolgolyov 9bc2dd91e2 feat(feature-planner): add pre-implementation plan reviewer + review hardening
Add a super-intensive, adversarial plan-reviewer agent that runs after the plan
is drafted and BEFORE the approval gate, to catch wasteful or wrong design
before any implementation effort is spent. Verdict can be REDESIGN REQUIRED;
findings are sorted into Critical Gaps (block) vs Suggestions (non-blocking) so
the two never get conflated at the approval gate. It must open the codebase to
verify claims (files exist, "no existing impl" holds, "parallel" phases are
disjoint). Conditional trigger: 4+ phases / Orchestrator / Automated /
security|data-sensitive. Wired into SKILL.md, discovery-and-planning (Step 5.5),
agent-spawning (spawn pattern + opus model profile + cost), and
modes-and-strategies (most valuable in Automated mode, the only human gate).

Review hardening also addressed:
- test-writer derives assertions from acceptance criteria, not the diff, so a
  failing test is signal (impl bug) rather than something to "fix" to match
  buggy behavior
- early per-phase security/data pass for sensitive phases (not only final review)
- Outstanding Warnings ledger in PLAN.md so non-blocking warnings can't
  accumulate invisibly across phases
- Automated-mode global circuit breaker (cost / agent-count cap)
- new `data` domain tag carrying a migration-safety addendum

Bump README Last updated date.
2026-06-01 12:25:02 +03:00
alexei.dolgolyov 04fe8124fc feat(feature-planner): major refactor — Task-tool spawning, progressive disclosure, bug fixes
SKILL.md shrunk from 1444 → 245 lines via progressive disclosure. Detailed
workflow content extracted into 8 reference files loaded only when needed.

Critical fixes
- Replace `claude -p` bash invocation with Task-tool spawn patterns (broken in
  VS Code extension, no hook/billing/telemetry inheritance, fails on PowerShell)
- Fix malformed Phase Progress Log table (header had 6 cols, row had 5 —
  every PLAN.md generated from the template was broken)
- Drop `/mnt/skills/public/` frontend-design path (Claude.ai sandbox only,
  never existed in CLI / VS Code / JetBrains installs)

High-impact additions
- Resume / abort triggers added to skill description ("continue feature",
  "resume planning", "pick up where we left off")
- Strategy behavior centralized in references/modes-and-strategies.md (was
  duplicated in 5+ places — drift was inevitable)
- references/resumability-and-abort.md adds a clean abort flow
- references/agent-spawning.md covers Task-tool patterns, parallel phases
  with git worktrees, MODEL_PROFILE cost overrides, local-only repo handling,
  and optional code-review-graph MCP integration
- Phase implementer agents now MUST scan CONTEXT.md `## Failed Approaches`
  before writing code (#1 source of duplicated mistakes across phases)
- Test writer / implementer division of labor made explicit (implementer
  writes happy-path tests, test writer adds adversarial coverage)
- New `## New Tooling Introduced` section in CONTEXT.md prevents tech-stack
  staleness across long features
- Local-only repo detection (probe `git remote -v` in Phase 1)
- Cost transparency: documented expected $5-25/feature and added
  `MODEL_PROFILE=fast|balanced|thorough` overrides

Structure
- SKILL.md: thin orchestrator (workflow outline + 18 key rules + agent
  table + Task-tool intro + cost note)
- references/: 8 files for on-demand detail
  - modes-and-strategies.md
  - resumability-and-abort.md
  - discovery-and-planning.md (Phase 0 + plan templates with FIXED table)
  - implementation-loop.md (Phase N + amendments)
  - context-management.md (4-tier system)
  - final-review-and-merge.md (final phase + rollback)
  - agent-spawning.md (Task tool / worktrees / cost / local-only repos)
  - tech-stack-analysis.md (slimmed — detection only, references rules
    system instead of duplicating best practices)
- agents/: phase-implementer.md and phase-implementer-frontend.md updated
  with mandatory Failed Approaches scan; test-writer.md gains division-of-
  labor section; other 5 agents unchanged
2026-05-16 20:02:44 +03:00
alexei.dolgolyov 93e4b3b5d0 chore: add model routing to feature-planner subagents
Assign explicit model frontmatter to all 8 feature-planner agents:
- sonnet: phase-implementer, phase-implementer-frontend, test-writer, conflict-resolver
- opus: phase-reviewer, final-reviewer, security-reviewer
- haiku: documentation-writer
2026-04-12 21:23:15 +03:00
alexei.dolgolyov 217132c3b7 chore: update feature-planner skill package 2026-04-07 19:41:44 +03:00
alexei.dolgolyov 0daa7f77ff docs: add skills directory and update README index
Add three packaged .skill files and document them in README:
dolgolyov-claude-facts, dolgolyov-git-release-publisher, feature-planner.
2026-03-25 15:50:24 +03:00