From fe97643a41e651c7e076002b213a9b0e8b570136 Mon Sep 17 00:00:00 2001 From: "alexei.dolgolyov" Date: Tue, 5 May 2026 12:35:01 +0300 Subject: [PATCH] =?UTF-8?q?fix(phase-4):=20close=20review=20notes=20?= =?UTF-8?q?=E2=80=94=20drop=20dead=20var,=20sync=20UI=20cron=20default?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Phase 4 reviewer (Sonnet) flagged two šŸŸ” warnings; both addressed: 1. PullLiveOddsUseCase: removed dead 'liveEvents' assignment that called ScrapeUpcomingAsync but never read the result. Replaced misleading comment block with a single TODO(phase-6/8) note pointing to the ListLiveAsync(cutoff) follow-up. 2. Marathon.UI.Services.WorkerOptions.UpcomingScheduleCron: changed default from '0 */5 * * * *' (every 5 min) to '0 0 */6 * * *' (every 6 hours) to match Marathon.Infrastructure.Configuration.WorkerOptions and the appsettings.json default. PLAN.md: Phase 4 row updated (review status, commit hash); top-level checkbox in Phases list ticked. Build 0/0, all 202 tests still passing. --- plans/initial-implementation/PLAN.md | 4 ++-- .../UseCases/PullLiveOddsUseCase.cs | 12 +++++------- src/Marathon.UI/Services/WorkerOptions.cs | 2 +- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/plans/initial-implementation/PLAN.md b/plans/initial-implementation/PLAN.md index 432a74c..086ff6d 100644 --- a/plans/initial-implementation/PLAN.md +++ b/plans/initial-implementation/PLAN.md @@ -38,7 +38,7 @@ parameter configurable. - [x] Phase 1: Solution skeleton + Domain model [domain: backend] ā†’ [subplan](./phase-1-solution-and-domain.md) - [ ] Phase 2: Infrastructure ā€” Storage [domain: backend] ā†’ [subplan](./phase-2-storage.md) - [ ] Phase 3: Infrastructure ā€” Scraping [domain: backend] ā†’ [subplan](./phase-3-scraping.md) -- [ ] Phase 4: Application layer + Background workers [domain: backend] ā†’ [subplan](./phase-4-application-and-workers.md) +- [x] Phase 4: Application layer + Background workers [domain: backend] ā†’ [subplan](./phase-4-application-and-workers.md) - [ ] Phase 5: Blazor Hybrid host + Theme + i18n [domain: frontend] ā†’ [subplan](./phase-5-host-theme-i18n.md) - [ ] Phase 6: Event browsing UI [domain: frontend] ā†’ [subplan](./phase-6-event-browsing-ui.md) - [ ] Phase 7: Anomaly detection [domain: fullstack] ā†’ [subplan](./phase-7-anomaly-detection.md) @@ -66,7 +66,7 @@ parameter configurable. | Phase 1: Solution + Domain | backend | āœ… Done | āš ļø Pass with notes (Sonnet) | āœ… Build OK + 96/96 Domain tests | āœ… 61114ea | | Phase 2: Storage | backend | āœ… Done | āš ļø Pass with notes (Sonnet, combined batch) | āœ… Build OK + 77/77 Infra tests | āœ… batch (e4d8476ā€¦686550dā€¦+) | | Phase 3: Scraping | backend | āœ… Done | āš ļø Pass with notes (Sonnet, combined batch) | āœ… Build OK + 77/77 Infra tests | āœ… batch (e4d8476ā€¦686550dā€¦+) | -| Phase 4: Application + Workers | backend | āœ… Done | ā¬œ | āœ… Build OK + 202/202 tests | ā¬œ | +| Phase 4: Application + Workers | backend | āœ… Done | āš ļø Pass with notes (Sonnet) | āœ… Build OK + 202/202 tests | āœ… 2acbaa5 | | Phase 5: Host + Theme + i18n | frontend | āœ… Done | āš ļø Pass with notes (Sonnet, combined batch) | āœ… Build OK + 11/11 UI tests | āœ… batch (e4d8476ā€¦686550dā€¦+) | | Phase 6: Event browsing UI | frontend | ā¬œ Not Started | ā¬œ | ā­ļø Big Bang | ā¬œ | | Phase 7: Anomaly detection | fullstack | ā¬œ Not Started | ā¬œ | ā­ļø Big Bang | ā¬œ | diff --git a/src/Marathon.Application/UseCases/PullLiveOddsUseCase.cs b/src/Marathon.Application/UseCases/PullLiveOddsUseCase.cs index 6fea2cf..a0bdfbe 100644 --- a/src/Marathon.Application/UseCases/PullLiveOddsUseCase.cs +++ b/src/Marathon.Application/UseCases/PullLiveOddsUseCase.cs @@ -36,13 +36,11 @@ public sealed class PullLiveOddsUseCase { _logger.LogInformation("PullLiveOddsUseCase: cycle started"); - // Fetch live events from scraper ā€” returns only events currently live on site. - var liveEvents = await _scraper.ScrapeUpcomingAsync(sportFilter: null, ct); - - // Note: the scraper's ScrapeUpcomingAsync returns pre-match by default. - // For the live cycle, we load known events from the DB and refresh each one. - // The "live vs pre-match" distinction is handled by OddsSource.Live in the snapshot. - // We use the DB list because the site's live listing may differ from what we track. + // Refresh odds for every event we already track. The "live vs pre-match" + // distinction is recorded by stamping each snapshot with OddsSource.Live. + // TODO(phase-6/8): once IEventRepository.ListLiveAsync(cutoff) ships, swap + // this for a filter that only returns currently-live events to avoid + // hammering the scraper with non-live IDs. var allEvents = await _eventRepo.ListAsync(ct); int snapshotsCaptured = 0; diff --git a/src/Marathon.UI/Services/WorkerOptions.cs b/src/Marathon.UI/Services/WorkerOptions.cs index e61c96c..5876449 100644 --- a/src/Marathon.UI/Services/WorkerOptions.cs +++ b/src/Marathon.UI/Services/WorkerOptions.cs @@ -9,7 +9,7 @@ public sealed class WorkerOptions public const string SectionName = "Workers"; /// Cron expression that drives the upcoming-schedule poller. - public string UpcomingScheduleCron { get; set; } = "0 */5 * * * *"; + public string UpcomingScheduleCron { get; set; } = "0 0 */6 * * *"; /// Whether the live odds poller should run at startup. public bool LivePollerEnabled { get; set; } = true;