Files
maraphon-app/tests/Marathon.Domain.Tests/Entities/EventTests.cs
T
alexei.dolgolyov 9c5d3df1f2 feat(phase-8-backend): per-event results harvesting + EventPath plumbing
Implements Phase 8 Amendment 1: marathonbet.by has no public results archive
endpoint, so results must be harvested per-event by re-fetching the event
detail page until eventJsonInfo.matchIsComplete=true.

Backend changes:

* IOddsScraper:
  - ScrapeResultsAsync(DateRange) replaced with ScrapeEventResultAsync(Event)
    returning a nullable EventResult — null when match still in progress.
  - ScrapeEventOddsAsync now takes the full Event (so EventPath drives URL
    construction) instead of bare EventId.
  - New ScrapeLiveAsync() for the /su/live listing.

* Domain:
  - Event gains EventPath (nullable string) — the data-event-path attribute
    captured during scraping; required for reliable URL construction.

* Infrastructure:
  - New migration 20260506000000_AddEventPath adds the column.
  - EventEntity / EventConfiguration / Mapping / model-snapshot updated.
  - MarathonbetScraper: new ScrapeLiveAsync + ScrapeEventResultAsync; URL
    builder prefers EventPath, falls back to numeric ID for legacy rows.
  - EventListingParserBase extracts data-event-path on every listing row.

* Application:
  - PullResultsUseCase: branches on selection vs date-range, emits IProgress<
    PullResultsProgress>, returns ResultLoadOutcome (Loaded / AlreadyLoaded /
    NotYetComplete / Failed); idempotent (skips events whose result already
    exists).
  - PullLiveOddsUseCase now drives off the live listing (auto-discovers
    events that go live without ever appearing in the upcoming list) and
    backfills EventPath on legacy rows.
  - PullUpcomingEventsUseCase wires EventPath on persisted events.

* Workers: UpcomingEventsPoller updates persistence path accordingly.

* Tests: 17 net-new tests across Application + Infrastructure + Domain;
  all 293 still pass.
2026-05-09 15:10:27 +03:00

141 lines
5.1 KiB
C#

using FluentAssertions;
using Marathon.Domain.Entities;
using Marathon.Domain.ValueObjects;
namespace Marathon.Domain.Tests.Entities;
public sealed class EventTests
{
private static readonly EventId SampleId = new("26456117");
private static readonly SportCode SampleSport = new(6);
private static readonly TimeSpan MoscowOffset = TimeSpan.FromHours(3);
private static readonly DateTimeOffset ValidScheduledAt =
new(2026, 5, 10, 18, 0, 0, MoscowOffset);
private static Event CreateValidEvent(DateTimeOffset? scheduledAt = null) =>
new(
SampleId,
SampleSport,
"RU",
"nba-league-1",
"Play-Offs",
scheduledAt ?? ValidScheduledAt,
"Арсенал",
"Атлетико");
[Fact]
public void Constructor_CreatesEvent_WhenAllParametersAreValid()
{
var evt = CreateValidEvent();
evt.Id.Should().Be(SampleId);
evt.Sport.Should().Be(SampleSport);
evt.ScheduledAt.Offset.Should().Be(MoscowOffset);
}
[Fact]
public void Constructor_ThrowsArgumentException_WhenScheduledAtIsNotMoscowTime()
{
// UTC+0 — wrong offset
var utcTime = new DateTimeOffset(2026, 5, 10, 15, 0, 0, TimeSpan.Zero);
var act = () => CreateValidEvent(utcTime);
act.Should().Throw<ArgumentException>()
.WithParameterName("ScheduledAt");
}
[Fact]
public void Constructor_ThrowsArgumentException_WhenScheduledAtIsOtherOffset()
{
// UTC+2 — wrong offset (CEST, for example)
var cestTime = new DateTimeOffset(2026, 5, 10, 17, 0, 0, TimeSpan.FromHours(2));
var act = () => CreateValidEvent(cestTime);
act.Should().Throw<ArgumentException>()
.WithParameterName("ScheduledAt");
}
[Fact]
public void ScheduledAt_Offset_IsMoscowTime()
{
var evt = CreateValidEvent();
evt.ScheduledAt.Offset.Should().Be(TimeSpan.FromHours(3));
}
[Fact]
public void Constructor_ThrowsArgumentNullException_WhenIdIsNull()
{
var act = () => new Event(null!, SampleSport, "RU", "l1", "cat", ValidScheduledAt, "A", "B");
act.Should().Throw<ArgumentNullException>().WithParameterName("Id");
}
[Fact]
public void Constructor_ThrowsArgumentNullException_WhenSportIsNull()
{
var act = () => new Event(SampleId, null!, "RU", "l1", "cat", ValidScheduledAt, "A", "B");
act.Should().Throw<ArgumentNullException>().WithParameterName("Sport");
}
[Theory]
[InlineData("")]
[InlineData(" ")]
public void Constructor_ThrowsArgumentException_WhenCountryCodeIsEmptyOrWhitespace(string code)
{
var act = () => new Event(SampleId, SampleSport, code, "l1", "cat", ValidScheduledAt, "A", "B");
act.Should().Throw<ArgumentException>().WithParameterName("CountryCode");
}
[Theory]
[InlineData("")]
[InlineData(" ")]
public void Constructor_ThrowsArgumentException_WhenLeagueIdIsEmptyOrWhitespace(string leagueId)
{
var act = () => new Event(SampleId, SampleSport, "RU", leagueId, "cat", ValidScheduledAt, "A", "B");
act.Should().Throw<ArgumentException>().WithParameterName("LeagueId");
}
[Theory]
[InlineData("")]
[InlineData(" ")]
public void Constructor_ThrowsArgumentException_WhenSide1NameIsEmptyOrWhitespace(string name)
{
var act = () => new Event(SampleId, SampleSport, "RU", "l1", "cat", ValidScheduledAt, name, "B");
act.Should().Throw<ArgumentException>().WithParameterName("Side1Name");
}
[Theory]
[InlineData("")]
[InlineData(" ")]
public void Constructor_ThrowsArgumentException_WhenSide2NameIsEmptyOrWhitespace(string name)
{
var act = () => new Event(SampleId, SampleSport, "RU", "l1", "cat", ValidScheduledAt, "A", name);
act.Should().Throw<ArgumentException>().WithParameterName("Side2Name");
}
[Fact]
public void Category_CanBeEmptyString()
{
// Category is optional (deep breadcrumbs may not exist)
var evt = new Event(SampleId, SampleSport, "RU", "l1", string.Empty, ValidScheduledAt, "A", "B");
evt.Category.Should().Be(string.Empty);
}
[Fact]
public void Event_IsImmutable_NoSettablePublicProperties()
{
var eventType = typeof(Event);
// Init-only setters (`init`) are immutable from a runtime perspective
// — they can only be assigned during object initialization, not later.
// The CLR encodes them with an `IsExternalInit` required custom modifier
// on the setter's return parameter.
static bool IsInitOnly(System.Reflection.MethodInfo setter) =>
setter.ReturnParameter
.GetRequiredCustomModifiers()
.Any(m => m.FullName == "System.Runtime.CompilerServices.IsExternalInit");
var settableProperties = eventType.GetProperties()
.Where(p => p.CanWrite && p.GetSetMethod(nonPublic: false) is { } setter && !IsInitOnly(setter))
.ToList();
settableProperties.Should().BeEmpty("Event must be immutable.");
}
}