alexei.dolgolyov
2ddbb93537
With the PyGObject girepository-2.0 fix in place, the linux-smoke step
ran its server-boot assertion for the first time and failed: on a fresh
runner the first-run bootstrap writes a default config and calls
sys.exit(0) ("First run: generated default config ... then restart")
instead of serving, so /api/health never came up and the 15s wait
timed out.
That exit-on-first-run is deliberate product behavior (never silently
start in insecure no-auth mode), so adjust the test rather than the app:
invoke the server once to seed the config (it exits 0 before binding the
port), then launch it for real. /api/health requires no auth, so the
auto-generated token is irrelevant to the check.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
107 lines
3.7 KiB
YAML
107 lines
3.7 KiB
YAML
name: Lint & Test
|
|
|
|
on:
|
|
push:
|
|
branches: [master]
|
|
pull_request:
|
|
branches: [master]
|
|
|
|
jobs:
|
|
test:
|
|
if: "!startsWith(github.event.head_commit.message, 'chore: release')"
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
|
|
- name: Build frontend
|
|
run: npm ci && npm run build
|
|
|
|
- uses: actions/setup-python@v5
|
|
with:
|
|
python-version: '3.11'
|
|
|
|
- name: Install dependencies
|
|
run: |
|
|
pip install --upgrade pip
|
|
pip install -e ".[dev]"
|
|
|
|
- name: Lint
|
|
run: ruff check media_server/
|
|
|
|
- name: Test
|
|
run: pytest --tb=short -q || test $? -eq 5
|
|
|
|
# Linux smoke test: install the linux extra in the same way build-dist-linux.sh
|
|
# does, then boot the server and hit /api/health. Catches dependency-resolution
|
|
# and import-time regressions for the Linux distribution path.
|
|
linux-smoke:
|
|
if: "!startsWith(github.event.head_commit.message, 'chore: release')"
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
|
|
- name: Build frontend
|
|
run: npm ci && npm run build
|
|
|
|
- uses: actions/setup-python@v5
|
|
with:
|
|
python-version: '3.11'
|
|
|
|
- name: Install Linux system deps for dbus-python + PyGObject
|
|
run: |
|
|
# PyGObject >= 3.52 builds against girepository-2.0 (merged into
|
|
# GLib 2.80), not the old standalone girepository-1.0. ubuntu-latest
|
|
# (24.04) ships it as libgirepository-2.0-dev.
|
|
sudo apt-get update
|
|
sudo apt-get install -y --no-install-recommends \
|
|
libdbus-1-dev libglib2.0-dev pkg-config \
|
|
libcairo2-dev libgirepository-2.0-dev
|
|
|
|
- name: Install with linux extra
|
|
run: |
|
|
pip install --upgrade pip
|
|
pip install ".[linux]"
|
|
|
|
- name: Smoke — server boots and /api/health responds
|
|
run: |
|
|
# Headless Linux runners have no PulseAudio and no display
|
|
# server, so we disable the visualizer + update checker, and we
|
|
# use `dbus-run-session` to give LinuxMediaController a real
|
|
# session bus to talk to (otherwise dbus.SessionBus() would
|
|
# raise during startup). This isn't a full MPRIS integration
|
|
# test — it only proves the dispatcher selects the Linux
|
|
# controller, all imports resolve, and /api/health returns 200.
|
|
sudo apt-get install -y --no-install-recommends dbus-x11
|
|
export MEDIA_SERVER_VISUALIZER_ENABLED=false
|
|
export MEDIA_SERVER_UPDATE_CHECK_ENABLED=false
|
|
dbus-run-session -- bash -c '
|
|
# First run writes a default config (random token) and exits 0
|
|
# instead of serving, so the server is never left running in
|
|
# insecure no-auth mode. Run once to seed the config; the real
|
|
# launch below then finds it and actually boots. /api/health needs
|
|
# no auth, so the generated token is irrelevant here.
|
|
python -m media_server.main --no-tray --port 18765 || true
|
|
python -m media_server.main --no-tray --port 18765 &
|
|
SERVER_PID=$!
|
|
for i in $(seq 1 30); do
|
|
if curl -sf "http://127.0.0.1:18765/api/health" >/dev/null; then
|
|
echo "Health check passed"
|
|
kill $SERVER_PID
|
|
wait $SERVER_PID 2>/dev/null || true
|
|
exit 0
|
|
fi
|
|
sleep 0.5
|
|
done
|
|
echo "Server did not respond within 15s"
|
|
kill $SERVER_PID 2>/dev/null || true
|
|
exit 1
|
|
'
|