feat: comprehensive code review fixes + receivers-only architecture

Security: - Refuse startup with default secret_key in production (was just logging) - Settings endpoint now requires admin role - Password validation on initial setup - DOM-based HTML sanitizer replaces regex in template previews - Add *.log to .gitignore Performance & reliability: - Token refresh deduplication prevents race condition on concurrent 401s - Theme media query listener registered once (no leak) - IconPicker uses $derived instead of function call per render - Snackbar uses single-batch state update instead of while loop - Replace 11 inline hover handlers with CSS :hover in layout Architecture - receivers-only: - Delivery endpoints (chat_id, email, url, room_id, topic) now stored exclusively in TargetReceiver rows, never in target.config - Migration extracts existing delivery fields to receiver rows - Notifier and dispatcher remove all config fallbacks - Frontend targets page shows receivers list per target with add/remove/toggle/test per receiver - Single-receiver test endpoint: POST /targets/{id}/receivers/{id}/test Code quality: - Extract AuthLayout.svelte from login/setup (150 lines CSS dedup) - Split telegram-bots page (754→51 lines + 3 tab components) - Split notification-trackers page (547→432 lines + 4 components) - Deduplicate _send_reply into shared handler.send_reply() - Add locale column to template models, replace name-based detection - Fix delete_notification_tracker dead protection check - Fix check_telegram_bot query (filter by type, remove bogus OR) - Add graceful scheduler shutdown in lifespan - Consistent /bots?tab=telegram URLs across all nav links i18n: - Error page, chat actions, target types, provider types internationalized - All new receiver UI strings in EN + RU
2026-03-22 02:19:31 +03:00
parent b525e3e7f4
commit 751097b347
43 changed files with 2584 additions and 1685 deletions
@@ -0,0 +1,156 @@
+<script lang="ts">
+	import { api } from '$lib/api';
+	import { t } from '$lib/i18n';
+	import { matrixBotsCache } from '$lib/stores/caches.svelte';
+	import PageHeader from '$lib/components/PageHeader.svelte';
+	import Card from '$lib/components/Card.svelte';
+	import IconPicker from '$lib/components/IconPicker.svelte';
+	import MdiIcon from '$lib/components/MdiIcon.svelte';
+	import EmptyState from '$lib/components/EmptyState.svelte';
+	import ConfirmModal from '$lib/components/ConfirmModal.svelte';
+	import IconButton from '$lib/components/IconButton.svelte';
+	import { snackSuccess, snackError } from '$lib/stores/snackbar.svelte';
+	import type { MatrixBot } from '$lib/types';
+
+	let { onreload }: { onreload: () => Promise<void> } = $props();
+
+	let matrixBots = $derived(matrixBotsCache.items);
+	let showMatrixForm = $state(false);
+	let editingMatrix = $state<number | null>(null);
+	let matrixSubmitting = $state(false);
+	let matrixTesting = $state<Record<number, boolean>>({});
+	let confirmDeleteMatrix = $state<any>(null);
+	let error = $state('');
+
+	const defaultMatrixForm = () => ({
+		name: '', icon: '', homeserver_url: '', access_token: '', display_name: '',
+	});
+	let matrixForm = $state(defaultMatrixForm());
+
+	function openNewMatrix() { matrixForm = defaultMatrixForm(); editingMatrix = null; showMatrixForm = true; }
+	function editMatrixBot(bot: MatrixBot) {
+		matrixForm = {
+			name: bot.name, icon: bot.icon || '',
+			homeserver_url: bot.homeserver_url, access_token: '',
+			display_name: bot.display_name || '',
+		};
+		editingMatrix = bot.id; showMatrixForm = true;
+	}
+
+	async function saveMatrixBot(e: SubmitEvent) {
+		e.preventDefault(); error = ''; matrixSubmitting = true;
+		try {
+			const body = { ...matrixForm };
+			if (editingMatrix && !body.access_token) delete (body as any).access_token;
+			if (editingMatrix) {
+				await api(`/matrix-bots/${editingMatrix}`, { method: 'PUT', body: JSON.stringify(body) });
+				snackSuccess(t('snack.matrixBotUpdated'));
+			} else {
+				await api('/matrix-bots', { method: 'POST', body: JSON.stringify(body) });
+				snackSuccess(t('snack.matrixBotCreated'));
+			}
+			matrixForm = defaultMatrixForm(); showMatrixForm = false; editingMatrix = null; await onreload();
+		} catch (err: any) { error = err.message; snackError(err.message); }
+		finally { matrixSubmitting = false; }
+	}
+
+	function removeMatrix(id: number) {
+		confirmDeleteMatrix = {
+			id,
+			onconfirm: async () => {
+				try { await api(`/matrix-bots/${id}`, { method: 'DELETE' }); await onreload(); snackSuccess(t('snack.matrixBotDeleted')); }
+				catch (err: any) { error = err.message; snackError(err.message); }
+				finally { confirmDeleteMatrix = null; }
+			}
+		};
+	}
+
+	async function testMatrixBot(botId: number) {
+		matrixTesting = { ...matrixTesting, [botId]: true };
+		try {
+			const res = await api(`/matrix-bots/${botId}/test`, { method: 'POST' });
+			if (res.success) snackSuccess(t('snack.matrixBotTestOk'));
+			else snackError(res.error || 'Failed');
+		} catch (err: any) { snackError(err.message); }
+		matrixTesting = { ...matrixTesting, [botId]: false };
+	}
+</script>
+
+<PageHeader title={t('matrixBot.title')} description={t('matrixBot.description')}>
+	<button onclick={() => { showMatrixForm ? (showMatrixForm = false, editingMatrix = null) : openNewMatrix(); }}
+		class="px-3 py-1.5 bg-[var(--color-primary)] text-[var(--color-primary-foreground)] rounded-md text-sm font-medium hover:opacity-90">
+		{showMatrixForm ? t('common.cancel') : t('matrixBot.addBot')}
+	</button>
+</PageHeader>
+
+{#if showMatrixForm}
+	<Card class="mb-6">
+		{#if error}<div class="bg-[var(--color-error-bg)] text-[var(--color-error-fg)] text-sm rounded-md p-3 mb-4">{error}</div>{/if}
+		<form onsubmit={saveMatrixBot} class="space-y-3">
+			<div>
+				<label for="mbot-name" class="block text-sm font-medium mb-1">{t('matrixBot.name')}</label>
+				<div class="flex gap-2">
+					<IconPicker value={matrixForm.icon} onselect={(v: string) => matrixForm.icon = v} />
+					<input id="mbot-name" bind:value={matrixForm.name} required placeholder={t('matrixBot.namePlaceholder')}
+						class="flex-1 px-3 py-2 border border-[var(--color-border)] rounded-md text-sm bg-[var(--color-background)]" />
+				</div>
+			</div>
+			<div>
+				<label for="mbot-hs" class="block text-sm font-medium mb-1">{t('matrixBot.homeserverUrl')}</label>
+				<input id="mbot-hs" bind:value={matrixForm.homeserver_url} required placeholder="https://matrix.org"
+					class="w-full px-3 py-2 border border-[var(--color-border)] rounded-md text-sm bg-[var(--color-background)]" />
+			</div>
+			<div>
+				<label for="mbot-token" class="block text-sm font-medium mb-1">{t('matrixBot.accessToken')}</label>
+				<input id="mbot-token" bind:value={matrixForm.access_token} type="password"
+					required={!editingMatrix}
+					placeholder={editingMatrix ? t('matrixBot.tokenUnchanged') : t('matrixBot.tokenPlaceholder')}
+					class="w-full px-3 py-2 border border-[var(--color-border)] rounded-md text-sm bg-[var(--color-background)] font-mono" />
+			</div>
+			<div>
+				<label for="mbot-display" class="block text-sm font-medium mb-1">{t('matrixBot.displayName')}</label>
+				<input id="mbot-display" bind:value={matrixForm.display_name} placeholder="Notify Bridge"
+					class="w-full px-3 py-2 border border-[var(--color-border)] rounded-md text-sm bg-[var(--color-background)]" />
+			</div>
+			<button type="submit" disabled={matrixSubmitting}
+				class="px-4 py-2 bg-[var(--color-primary)] text-[var(--color-primary-foreground)] rounded-md text-sm font-medium hover:opacity-90 disabled:opacity-50">
+				{matrixSubmitting ? t('common.loading') : (editingMatrix ? t('common.save') : t('matrixBot.addBot'))}
+			</button>
+		</form>
+	</Card>
+{/if}
+
+{#if matrixBots.length === 0 && !showMatrixForm}
+	<Card>
+		<EmptyState icon="mdiMatrix" message={t('matrixBot.noBots')} />
+	</Card>
+{:else}
+	<div class="space-y-3 stagger-children">
+		{#each matrixBots as bot}
+			<Card hover entityId={bot.id}>
+				<div class="flex items-center justify-between">
+					<div>
+						<div class="flex items-center gap-2">
+							<span style="color: var(--color-primary);"><MdiIcon name={bot.icon || 'mdiMatrix'} size={20} /></span>
+							<p class="font-medium">{bot.name}</p>
+						</div>
+						<div class="flex items-center gap-2 mt-1 flex-wrap">
+							<span class="text-xs text-[var(--color-muted-foreground)] font-mono">{bot.homeserver_url}</span>
+							{#if bot.display_name}
+								<span class="text-xs px-1.5 py-0.5 rounded bg-[var(--color-muted)] text-[var(--color-muted-foreground)]">{bot.display_name}</span>
+							{/if}
+						</div>
+					</div>
+					<div class="flex items-center gap-1">
+						<IconButton icon="mdiConnection" title={t('matrixBot.testConnection')} onclick={() => testMatrixBot(bot.id)} disabled={matrixTesting[bot.id]} />
+						<IconButton icon="mdiPencil" title={t('common.edit')} onclick={() => editMatrixBot(bot)} />
+						<IconButton icon="mdiDelete" title={t('common.delete')} onclick={() => removeMatrix(bot.id)} variant="danger" />
+					</div>
+				</div>
+			</Card>
+		{/each}
+	</div>
+{/if}
+
+<ConfirmModal open={confirmDeleteMatrix !== null} message={t('matrixBot.confirmDelete')}
+	onconfirm={() => confirmDeleteMatrix?.onconfirm()} oncancel={() => confirmDeleteMatrix = null} />