refactor: comprehensive codebase review — security, performance, quality, UX

Security: - Fix NUT protocol command injection (validate names against safe regex) - Enable Jinja2 autoescape=True to prevent HTML injection via external data - Add WebhookProviderConfig validation model Performance: - Shared aiohttp.ClientSession singleton (replaces 40+ per-request sessions) - Fix 4 N+1 queries with batch IN loads (poller, scheduler, memory, broadcast) - asyncio.gather for Gitea commands and notification dispatcher - Add DB indexes on NotificationTrackerState.tracker_id, CommandTrackerListener - LRU cache for compiled Jinja2 templates - Daily EventLog cleanup job (90-day retention) - 30s HTTP timeout on all external calls - GROUP BY for target type counts (replaces 7 sequential queries) Code quality: - Extract get_owned_entity() helper (replaces 11 duplicate functions) - Extract slot_helpers.py (load_slots, save_slots, render_template_preview) - Extract command_utils.py (tracker lookup, last event, collection IDs) - Extract http_session.py (shared session lifecycle) - Provider connection validation dedup (3x → 1 helper) - Command dispatch tables replacing if/elif chains - Album+links fetch helper (fetch_albums_with_links) - Provider dispatch polymorphism (list_provider_collections) - Immutable _enrich_assets (no longer mutates in-place) - Fix _format_assets return type + handler unpacking Frontend: - Fix 18+ hardcoded English strings → t() with new i18n keys (en + ru) - Mobile "More" nav panel with provider filter and search - Shared Button.svelte component (4 variants, 2 sizes) - Shared ErrorBanner.svelte component (8 pages updated) - SvelteKit goto() replacing window.location.href - Dashboard grid fixed for 4 cards, paginator opacity consistency Functionality: - max_instances=1 on scheduler jobs (prevents duplicate events) - Webhook provider in watcher (prevents error spam) - Fix stale SQLModel reference in poller - Gitea get_repo() direct API call
2026-03-28 13:22:26 +03:00
parent 616b221c92
commit b803d004e1
65 changed files with 1934 additions and 1498 deletions
@@ -7,7 +7,6 @@ objects and dispatches through the same path the watcher uses.
 import logging
 from typing import Any

-import aiohttp
 from sqlmodel import select
 from sqlmodel.ext.asyncio.session import AsyncSession

@@ -183,58 +182,59 @@ async def _build_immich_event(
    memory_source = getattr(tracking_config, "memory_source", "albums") if tracking_config else "albums"
    is_memory = test_type == "memory"

-    async with aiohttp.ClientSession() as http_session:
-        immich = ImmichServiceProvider(
-            http_session,
-            provider_config.get("url", ""),
-            provider_config.get("api_key", ""),
-            provider_config.get("external_domain"),
-            provider_name,
-        )
-        if not await immich.connect():
-            return None
+    from .http_session import get_http_session
+    http_session = await get_http_session()
+    immich = ImmichServiceProvider(
+        http_session,
+        provider_config.get("url", ""),
+        provider_config.get("api_key", ""),
+        provider_config.get("external_domain"),
+        provider_name,
+    )
+    if not await immich.connect():
+        return None

-        # Native Immich memories API path
-        if is_memory and memory_source == "native":
-            return await _build_native_memory_event(
-                immich, ext_domain, provider_name, tracker_name,
-                collection_ids, limit, asset_type, favorite_only, min_rating,
-            )
-
-        # Album-based path: use shared collect_scheduled_assets
-        albums: dict[str, ImmichAlbumData] = {}
-        shared_links: dict[str, list[SharedLinkInfo]] = {}
-        for album_id in collection_ids:
-            album = await immich.client.get_album(album_id)
-            if album:
-                albums[album_id] = album
-                shared_links[album_id] = await immich.client.get_shared_links(album_id)
-
-        assets, collections_extra = collect_scheduled_assets(
-            albums, shared_links, ext_domain,
-            limit=limit,
-            asset_type=asset_type,
-            favorite_only=favorite_only,
-            min_rating=min_rating,
-            is_memory=is_memory,
+    # Native Immich memories API path
+    if is_memory and memory_source == "native":
+        return await _build_native_memory_event(
+            immich, ext_domain, provider_name, tracker_name,
+            collection_ids, limit, asset_type, favorite_only, min_rating,
        )

-        first_col = collections_extra[0] if collections_extra else {}
-        return ServiceEvent(
-            event_type=EventType.SCHEDULED_MESSAGE,
-            provider_type=ServiceProviderType.IMMICH,
-            provider_name=provider_name,
-            collection_id=collection_ids[0] if collection_ids else "",
-            collection_name=first_col.get("name", tracker_name),
-            timestamp=datetime.now(timezone.utc),
-            added_assets=assets,
-            added_count=len(assets),
-            extra={
-                "collections": collections_extra,
-                "albums": collections_extra,
-                **(first_col if first_col else {}),
-            },
-        )
+    # Album-based path: use shared collect_scheduled_assets
+    albums: dict[str, ImmichAlbumData] = {}
+    shared_links: dict[str, list[SharedLinkInfo]] = {}
+    for album_id in collection_ids:
+        album = await immich.client.get_album(album_id)
+        if album:
+            albums[album_id] = album
+            shared_links[album_id] = await immich.client.get_shared_links(album_id)
+
+    assets, collections_extra = collect_scheduled_assets(
+        albums, shared_links, ext_domain,
+        limit=limit,
+        asset_type=asset_type,
+        favorite_only=favorite_only,
+        min_rating=min_rating,
+        is_memory=is_memory,
+    )
+
+    first_col = collections_extra[0] if collections_extra else {}
+    return ServiceEvent(
+        event_type=EventType.SCHEDULED_MESSAGE,
+        provider_type=ServiceProviderType.IMMICH,
+        provider_name=provider_name,
+        collection_id=collection_ids[0] if collection_ids else "",
+        collection_name=first_col.get("name", tracker_name),
+        timestamp=datetime.now(timezone.utc),
+        added_assets=assets,
+        added_count=len(assets),
+        extra={
+            "collections": collections_extra,
+            "albums": collections_extra,
+            **(first_col if first_col else {}),
+        },
+    )


 async def _build_native_memory_event(