alexei.dolgolyov
b803d004e1
Security: - Fix NUT protocol command injection (validate names against safe regex) - Enable Jinja2 autoescape=True to prevent HTML injection via external data - Add WebhookProviderConfig validation model Performance: - Shared aiohttp.ClientSession singleton (replaces 40+ per-request sessions) - Fix 4 N+1 queries with batch IN loads (poller, scheduler, memory, broadcast) - asyncio.gather for Gitea commands and notification dispatcher - Add DB indexes on NotificationTrackerState.tracker_id, CommandTrackerListener - LRU cache for compiled Jinja2 templates - Daily EventLog cleanup job (90-day retention) - 30s HTTP timeout on all external calls - GROUP BY for target type counts (replaces 7 sequential queries) Code quality: - Extract get_owned_entity() helper (replaces 11 duplicate functions) - Extract slot_helpers.py (load_slots, save_slots, render_template_preview) - Extract command_utils.py (tracker lookup, last event, collection IDs) - Extract http_session.py (shared session lifecycle) - Provider connection validation dedup (3x → 1 helper) - Command dispatch tables replacing if/elif chains - Album+links fetch helper (fetch_albums_with_links) - Provider dispatch polymorphism (list_provider_collections) - Immutable _enrich_assets (no longer mutates in-place) - Fix _format_assets return type + handler unpacking Frontend: - Fix 18+ hardcoded English strings → t() with new i18n keys (en + ru) - Mobile "More" nav panel with provider filter and search - Shared Button.svelte component (4 variants, 2 sizes) - Shared ErrorBanner.svelte component (8 pages updated) - SvelteKit goto() replacing window.location.href - Dashboard grid fixed for 4 cards, paginator opacity consistency Functionality: - max_instances=1 on scheduler jobs (prevents duplicate events) - Webhook provider in watcher (prevents error spam) - Fix stale SQLModel reference in poller - Gitea get_repo() direct API call
26 lines
691 B
Python
26 lines
691 B
Python
"""Shared helpers for API route modules."""
|
|
|
|
from typing import TypeVar
|
|
|
|
from fastapi import HTTPException
|
|
from sqlmodel import SQLModel
|
|
from sqlmodel.ext.asyncio.session import AsyncSession
|
|
|
|
T = TypeVar("T", bound=SQLModel)
|
|
|
|
|
|
async def get_owned_entity(
|
|
session: AsyncSession,
|
|
model: type[T],
|
|
entity_id: int,
|
|
user_id: int,
|
|
*,
|
|
owner_field: str = "user_id",
|
|
not_found_msg: str = "Not found",
|
|
) -> T:
|
|
"""Fetch an entity by PK and verify ownership, or raise 404."""
|
|
entity = await session.get(model, entity_id)
|
|
if not entity or getattr(entity, owner_field) != user_id:
|
|
raise HTTPException(status_code=404, detail=not_found_msg)
|
|
return entity
|