10d30fc956
Comprehensive multi-area pass driven by a parallel 8-agent production
review. Frontend, backend, database, security, performance, operational,
plus a new self-monitoring feature.
## Critical fixes
- Planka webhook: reads bounded raw body (was NameError on every call)
- HA quiet hours: ha_state_changed/automation_triggered/service_called/
event_fired added to deferrable set (were silently dropped)
- DNS-rebinding SSRF: PinnedResolver wired into shared aiohttp session
- Telegram inbound webhook: secret now mandatory (401 without)
- Generic webhook: auth_mode="none" requires explicit
acknowledge_unauthenticated=true; per-IP rate limit 60/min
- svelte-check: 5 null-narrowing errors in EventDetailModal fixed
- Provider hardcoding: Immich-only block extracted to descriptor
featureDiscoveryHint
- command_sync: snapshot+expunge bot before exiting AsyncSession
## Bug fixes
- notifier asyncio.gather(return_exceptions=True) — one bad chat no longer
cancels peer sends
- NotificationDispatcher hoisted out of per-tracker loop
- Provider credential resolution unified across all 5 dispatch sites
- HA asyncio.shield now drains inner task on cancellation
- Provider construction switched from if/elif ladder to factory registry
- NUT first poll seeds silently (no spurious ups_on_battery)
- Quiet-hours gate: event-type-disabled now wins over deferral
- APScheduler drain job ID resolution upgraded to seconds
- HA on_status_change wired through to EventLog
- Webhook payload rollback failures now logged (not swallowed)
- Batched receivers/chats/bots in load_link_data (was per-target N+1)
- flag_modified on JSON column reassignments in deferred_dispatch
## Database
- UNIQUE indexes on service_provider.webhook_token,
telegram_bot.webhook_path_id, partial UNIQUE on telegram_bot.bot_id,
telegram_chat(bot_id, chat_id), notification_tracker_target unique link,
partial UNIQUE on bridge_self provider per user
- Composite ix_event_log_user_event_type_created index
- save_chat_from_webhook switched to ON CONFLICT DO UPDATE
- ondelete=CASCADE on user-id FKs (model annotation; app-side cascade
delete added for existing data)
- delete_notification_tracker converted from N+1 to bulk DELETE/UPDATE
- Module-level asyncio.Lock replaced with lazy _get_lock() pattern
- VACUUM INTO snapshot now PRAGMA integrity_check verified
## Performance
- Jinja2 template compilation LRU cached (lru_cache maxsize=512)
- Per-locale render cache in NotificationDispatcher (skips re-rendering
identical content for receivers sharing a locale)
- Tracker list cached per provider_id with 5s TTL + explicit invalidation
on tracker CRUD (relieves HA chat-bus rate query pressure)
- Nav-counts collapsed from 16 round-trips to single UNION ALL
- HA event_log: skip persisting empty assets_added/removed events
## Security hardening
- Mass-assignment guard on Action create/update; cron sub-minute reject
- Backup JSON depth/node-count cap (depth ≤ 10, nodes ≤ 100k)
- _sanitize_config extended to all JSON-typed fields on backup import
- Telegram _safe_get walks redirects manually with SSRF revalidation
- Bcrypt 72-byte password length cap with clear 422
- Webhook payload body redaction; sensitive substring set extended with
oauth/client_secret/webhook_secret/csrf in both header filter and
template extras filter
## Frontend
- 76 catch (err: any) sites converted to errMsg(err) helper
- globalProviderFilter: pure getter; reconciliation moved to one-time
$effect in +layout
- Provider-filter binding: removed paired $effects + _syncingFilter flag,
now one-way derived
- entity-cache: separate _refreshing flag for background re-fetches
- api.ts 401 handling: AuthRedirectError class + dedup _redirecting flag,
goto() instead of window.location.href
- a11y: aria-expanded on mobile More, role=switch + aria-checked on
Telegram bot toggles
## Tests & operations
- CI pytest gate added to .gitea/workflows/build.yml + release.yml
(wheel-built install to dodge editable-install slowness)
- /api/ready upgraded to deep healthcheck (db SELECT 1, scheduler.running,
HA supervisor presence) returning {ready, checks, errors, version}
- /api/metrics endpoint with prometheus_client (deferred_pending,
event_log_total, dispatch_duration, poll_failures, send_failures)
- New OPERATIONS.md covering deploy, healthchecks, metrics, backup/restore
procedures, log handling, common scenarios, upgrade flow
- New tests: test_bridge_self (11), test_gitea_parser (9),
test_planka_parser (6), test_immich_change_detector (6),
test_backup_roundtrip (1)
## New feature: bridge self-monitoring
- New bridge_self provider type — internal sink for bridge health events
- Three event types: bridge_self_poll_failures (consecutive tracker poll
failures), bridge_self_deferred_backlog (pending count crosses
threshold), bridge_self_target_failures (consecutive 5xx/network
failures per target)
- Per-user thresholds (defaults: 3 / 100 / 5) configurable via the
provider config form
- Auto-seeded on user create + /setup + boot backfill for existing users
- Anti-spam: counters reset after emission; backlog uses transition latch
- Self-loop guard: bridge_self failures don't count toward target-failure
thresholds (logged only) — wire to your own Telegram/Email/Matrix to
get notified when polls/dispatches/sends fail
- 6 default templates (3 events × 2 locales), tracking config columns
with backfill migration, frontend descriptor (excluded from "create
provider" wizard since auto-managed)
Operator-visible behavior changes (call out in release notes):
- NOTIFY_BRIDGE_TELEGRAM_WEBHOOK_SECRET now REQUIRED for webhook mode
- Existing webhook providers with auth_mode="none" need explicit opt-in
- Generic webhook endpoint rate-limited 60/min per source IP
- HA disconnect/reconnect writes ha_status_* EventLog rows
- Every user gets a bridge_self provider — wire it to a target to
receive failure alerts
Pre-existing test failures (test_ssrf, test_release_provider) on
Python 3.13 are unrelated; CI runs on 3.12.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
95 lines
4.5 KiB
Svelte
95 lines
4.5 KiB
Svelte
<script lang="ts">
|
|
import { t } from '$lib/i18n';
|
|
import { api , errMsg} from '$lib/api';
|
|
import { snackError, snackSuccess } from '$lib/stores/snackbar.svelte';
|
|
import Modal from '$lib/components/Modal.svelte';
|
|
import MdiIcon from '$lib/components/MdiIcon.svelte';
|
|
|
|
interface AlbumIssue { id: string; name: string; issue: string }
|
|
|
|
interface Props {
|
|
linkWarning: { albums: AlbumIssue[]; providerId: number } | null;
|
|
linkCreating: boolean;
|
|
onclose: () => void;
|
|
onautoCreate: () => void;
|
|
ondismiss: () => void;
|
|
/** Called with the updated warning list after a per-row replace. */
|
|
onupdate?: (albums: AlbumIssue[]) => void;
|
|
}
|
|
|
|
let { linkWarning, linkCreating, onclose, onautoCreate, ondismiss, onupdate }: Props = $props();
|
|
|
|
/** Per-row loading state for the "Replace" button. */
|
|
let replacing = $state<Record<string, boolean>>({});
|
|
|
|
/**
|
|
* Expired and password-protected links can't be repaired in place — the
|
|
* Immich API has no "reset" endpoint. The only remedy is to recreate the
|
|
* link (which the backend does by POSTing a new one and returning it).
|
|
* We surface the action per-row so users don't have to leave the form.
|
|
*/
|
|
async function replaceOne(album: AlbumIssue) {
|
|
if (!linkWarning) return;
|
|
replacing = { ...replacing, [album.id]: true };
|
|
try {
|
|
await api(`/providers/${linkWarning.providerId}/albums/${album.id}/shared-links`, {
|
|
method: 'POST',
|
|
body: JSON.stringify({ replace: true }),
|
|
});
|
|
snackSuccess(t('notificationTracker.createdLinks').replace('{count}', '1'));
|
|
const remaining = linkWarning.albums.filter(a => a.id !== album.id);
|
|
if (onupdate) onupdate(remaining);
|
|
} catch (err: unknown) {
|
|
snackError(t('notificationTracker.linkReplaceFailed').replace('{name}', album.name) + ': ' + errMsg(err));
|
|
} finally {
|
|
replacing = { ...replacing, [album.id]: false };
|
|
}
|
|
}
|
|
</script>
|
|
|
|
<Modal open={linkWarning !== null} title={t('notificationTracker.missingLinksTitle')} onclose={onclose}>
|
|
{#if linkWarning}
|
|
<p class="text-sm mb-3" style="color: var(--color-muted-foreground);">
|
|
{t('notificationTracker.missingLinksDesc')}
|
|
</p>
|
|
<div class="space-y-1.5 mb-4 max-h-60 overflow-y-auto">
|
|
{#each linkWarning.albums as album}
|
|
<div class="flex items-center justify-between gap-2 text-sm px-2 py-1.5 rounded bg-[var(--color-muted)]/30">
|
|
<div class="flex-1 min-w-0">
|
|
<span class="font-medium truncate block">{album.name}</span>
|
|
{#if album.issue === 'password-protected'}
|
|
<span class="text-[10px] block" style="color: var(--color-muted-foreground);">
|
|
{t('notificationTracker.linkPasswordProtectedNote')}
|
|
</span>
|
|
{/if}
|
|
</div>
|
|
<span class="text-xs px-1.5 py-0.5 rounded shrink-0 {album.issue === 'expired' ? 'bg-[var(--color-error-bg)] text-[var(--color-error-fg)]' : album.issue === 'password-protected' ? 'bg-[var(--color-warning-bg)] text-[var(--color-warning-fg)]' : 'bg-[var(--color-muted)] text-[var(--color-muted-foreground)]'}">
|
|
{album.issue === 'expired' ? t('notificationTracker.expired') : album.issue === 'password-protected' ? t('notificationTracker.passwordProtected') : t('notificationTracker.noLink')}
|
|
</span>
|
|
{#if album.issue === 'expired' || album.issue === 'password-protected'}
|
|
<button type="button" onclick={() => replaceOne(album)} disabled={replacing[album.id]}
|
|
class="text-xs px-2 py-1 rounded border border-[var(--color-border)] hover:bg-[var(--color-muted)] disabled:opacity-50 shrink-0">
|
|
{replacing[album.id] ? t('notificationTracker.linkReplacing') : t('notificationTracker.linkReplace')}
|
|
</button>
|
|
{/if}
|
|
</div>
|
|
{/each}
|
|
</div>
|
|
<p class="text-xs mb-4" style="color: var(--color-muted-foreground);">
|
|
<MdiIcon name="mdiInformation" size={14} /> {t('notificationTracker.linksNote')}
|
|
</p>
|
|
<div class="flex items-center gap-2 justify-end">
|
|
<button onclick={ondismiss}
|
|
class="px-3 py-1.5 text-sm border border-[var(--color-border)] rounded-md hover:bg-[var(--color-muted)]">
|
|
{t('notificationTracker.saveWithoutLinks')}
|
|
</button>
|
|
{#if linkWarning.albums.some(a => a.issue === 'missing')}
|
|
<button onclick={onautoCreate} disabled={linkCreating}
|
|
class="px-3 py-1.5 text-sm bg-[var(--color-primary)] text-[var(--color-primary-foreground)] rounded-md hover:opacity-90 disabled:opacity-50">
|
|
{linkCreating ? t('common.loading') : t('notificationTracker.createLinks').replace('{count}', String(linkWarning.albums.filter(a => a.issue === 'missing').length))}
|
|
</button>
|
|
{/if}
|
|
</div>
|
|
{/if}
|
|
</Modal>
|