From 2c109913bd5ad40aa4c50328db90d8fce264504d Mon Sep 17 00:00:00 2001 From: "alexei.dolgolyov" Date: Thu, 7 May 2026 02:17:20 +0300 Subject: [PATCH] fix(types): resolve pre-existing svelte-check errors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit stale-containers page referenced container.id but StaleContainer wraps an inner instance object — switch to container.instance.id at the three call sites. env editor derived projectId from $page.params.id (string | undefined); coalesce to empty string so call sites that pass it to API helpers don't trip the strictNullChecks gate. Pre-existing errors flagged by `svelte-check`; not introduced by recent feature work but blocking the green check. --- web/src/routes/containers/stale/+page.svelte | 6 +++--- web/src/routes/projects/[id]/env/+page.svelte | 5 ++++- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/web/src/routes/containers/stale/+page.svelte b/web/src/routes/containers/stale/+page.svelte index bb442bb..f720291 100644 --- a/web/src/routes/containers/stale/+page.svelte +++ b/web/src/routes/containers/stale/+page.svelte @@ -41,7 +41,7 @@ cleaningIds = new Set([...cleaningIds, id]); try { await api.cleanupStaleContainer(id); - containers = containers.filter((c) => c.id !== id); + containers = containers.filter((c) => c.instance.id !== id); toasts.success($t('stale.cleanedUp')); } catch (e) { toasts.error(e instanceof Error ? e.message : $t('stale.cleanupFailed')); @@ -124,10 +124,10 @@ /> {:else}
- {#each containers as container (container.id)} + {#each containers as container (container.instance.id)} {/each} diff --git a/web/src/routes/projects/[id]/env/+page.svelte b/web/src/routes/projects/[id]/env/+page.svelte index b865ef8..fee6978 100644 --- a/web/src/routes/projects/[id]/env/+page.svelte +++ b/web/src/routes/projects/[id]/env/+page.svelte @@ -40,7 +40,10 @@ let editProjectValue = $state(''); let projectEnvDeleteTarget = $state(null); - const projectId = $derived($page.params.id); + // $page.params.id is typed string | undefined because SvelteKit can't + // statically prove the [id] segment is present, but inside this route file + // it always is — assert non-null so call sites don't need their own guards. + const projectId = $derived($page.params.id ?? ''); async function handleAddProjectEnv() { if (!newProjectKey.trim()) return;