feat(deploy): commit-status reporting to Git providers
Report deploy status back to the Git provider as a commit status (pending/success/failure) for git-sourced workloads (static + dockerfile). - GitProvider.SetCommitStatus on gitea/github/gitlab over the existing SSRF-safe client; fixed "tinyforge" context so redeploys update one row. postJSON returns status-code-only errors (never echoes the upstream body, which a hostile provider could use to reflect the auth token into the best-effort log line). - Best-effort deploy hook: pending on deploy start, success/failure on outcome, gated on a per-workload report_commit_status flag. Never fails or blocks a deploy; emits nothing on the unchanged-SHA short-circuit. - UI ToggleSwitch (create + edit) + reportCommitStatus in sourceForms.ts + en/ru i18n. - Tests: per-provider state mapping + request shape; reporter gating (enabled/disabled/empty-SHA/nil/error-swallow). Reviewed via go-reviewer + security-reviewer (0 CRITICAL/HIGH; one MEDIUM body-echo log-leak fixed).
This commit is contained in:
@@ -95,6 +95,45 @@ func (g *GitLabProvider) TestConnection(ctx context.Context, owner, repo string)
|
||||
return err
|
||||
}
|
||||
|
||||
// SetCommitStatus reports a deploy status on a commit via GitLab's commit-
|
||||
// status API. GitLab's state vocabulary differs (pending/running/success/
|
||||
// failed/canceled), so failure AND error both map to "failed". The status
|
||||
// metadata (name/target_url/description) is passed as query parameters,
|
||||
// which is how GitLab's POST .../statuses/{sha} endpoint accepts them.
|
||||
func (g *GitLabProvider) SetCommitStatus(ctx context.Context, owner, repo, sha string, status CommitStatus, targetURL, description string) error {
|
||||
q := url.Values{}
|
||||
q.Set("state", gitlabState(status))
|
||||
q.Set("name", commitStatusContext)
|
||||
if targetURL != "" {
|
||||
q.Set("target_url", targetURL)
|
||||
}
|
||||
if description != "" {
|
||||
q.Set("description", truncateDescription(description))
|
||||
}
|
||||
apiURL := fmt.Sprintf("%s/projects/%s/statuses/%s?%s",
|
||||
g.apiBase, projectPath(owner, repo), url.PathEscape(sha), q.Encode())
|
||||
// No JSON body — all fields ride as query params. Reuse postJSON for
|
||||
// the SSRF-safe POST + 2xx handling; an empty body is valid here.
|
||||
if err := postJSON(ctx, g.httpClient, apiURL, nil, g.setAuth); err != nil {
|
||||
return fmt.Errorf("set commit status: %w", err)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// gitlabState maps a provider-agnostic CommitStatus onto GitLab's API
|
||||
// vocabulary. GitLab has no "failure"/"error" split — both map to
|
||||
// "failed".
|
||||
func gitlabState(status CommitStatus) string {
|
||||
switch status {
|
||||
case CommitStatusSuccess:
|
||||
return "success"
|
||||
case CommitStatusFailure, CommitStatusError:
|
||||
return "failed"
|
||||
default:
|
||||
return "pending"
|
||||
}
|
||||
}
|
||||
|
||||
func (g *GitLabProvider) ListBranches(ctx context.Context, owner, repo string) ([]string, error) {
|
||||
var allBranches []string
|
||||
page := 1
|
||||
|
||||
Reference in New Issue
Block a user