feat(apps): stepped creation wizard, branch previews, and app-creation fixes
This session (frontend focus):
- Rebuild /apps/new as a 4-step wizard (Basics → Configure → Trigger → Review):
WizardRail, SourceKindPicker card grid, AppManifest review, per-step validation,
ConfirmDialog-based unsaved-changes guard.
- Extract lib/workload/sourceForms.ts (single source of truth for source_config)
+ {Image,Compose,Static,Dockerfile}SourceForm + StaticDiscoveryWizard; fold the
/apps/[id] edit form onto the same components (removes the duplication). Add
vitest + sourceForms unit tests.
- Branch preview environments UI: /chain is_preview/preview_branch + a Preview
environments panel on /apps/[id] (per-branch URLs, ConfirmDialog teardown, armed
state); RegistryImagePicker on the registry trigger and the image source.
- Fixes: image-inspect 404 -> admin-gated POST /api/discovery/image/inspect;
conflict-panel blur flicker; friendly localized discovery errors; CPU/Memory
label hints; dashboard + /apps "Total workloads" count only source_kind workloads
(drop stale trigger_kind gate); NPM cert/access-list name cache; EntityPicker
empty-list guard.
- Update CLAUDE.md frontend conventions + add a Build & Test section.
Also captures pre-existing in-progress platform work (not from this session):
workload notifications, Prometheus metrics export, store lockfile, health probes,
backup hardening, and related store/webhook/scheduler changes.
This commit is contained in:
@@ -80,26 +80,55 @@ func loadState(deps plugin.Deps, w plugin.Workload) (runtimeState, *store.Contai
|
||||
// container_id / proxy_route_id and orphaning Docker resources. The
|
||||
// mutex caps the concurrency at 1 per workload; cross-workload
|
||||
// parallelism is unaffected.
|
||||
//
|
||||
// Entries are reference-counted and removed only when the last holder
|
||||
// releases. This bounds memory (no per-workload-ID leak) WITHOUT the
|
||||
// use-after-delete hazard of deleting an entry on teardown: deleting a
|
||||
// live entry while a concurrent saveState still holds (or is about to
|
||||
// lock) it would let a fresh saveState mint a SECOND mutex for the same
|
||||
// workload, losing the RMW serialization the lock exists to provide.
|
||||
var saveLocks struct {
|
||||
mu sync.Mutex
|
||||
locks map[string]*sync.Mutex
|
||||
locks map[string]*saveLock
|
||||
}
|
||||
|
||||
// lockFor returns the per-workload mutex, creating it on first use.
|
||||
// The outer mutex is held only briefly during map lookup; the returned
|
||||
// per-workload lock is what callers actually contend on.
|
||||
func lockFor(workloadID string) *sync.Mutex {
|
||||
type saveLock struct {
|
||||
mu sync.Mutex
|
||||
refs int
|
||||
}
|
||||
|
||||
// acquireSaveLock returns the per-workload lock (creating it on first use),
|
||||
// registers this caller as a holder, and takes the lock. Pair with
|
||||
// releaseSaveLock. The outer mutex is held only for the bookkeeping; callers
|
||||
// contend on the returned per-workload lock.
|
||||
func acquireSaveLock(workloadID string) *saveLock {
|
||||
saveLocks.mu.Lock()
|
||||
defer saveLocks.mu.Unlock()
|
||||
if saveLocks.locks == nil {
|
||||
saveLocks.locks = map[string]*sync.Mutex{}
|
||||
saveLocks.locks = map[string]*saveLock{}
|
||||
}
|
||||
m, ok := saveLocks.locks[workloadID]
|
||||
l, ok := saveLocks.locks[workloadID]
|
||||
if !ok {
|
||||
m = &sync.Mutex{}
|
||||
saveLocks.locks[workloadID] = m
|
||||
l = &saveLock{}
|
||||
saveLocks.locks[workloadID] = l
|
||||
}
|
||||
return m
|
||||
l.refs++
|
||||
saveLocks.mu.Unlock()
|
||||
l.mu.Lock()
|
||||
return l
|
||||
}
|
||||
|
||||
// releaseSaveLock unlocks and drops the caller's reference, removing the map
|
||||
// entry once no holders remain. Because refs is incremented under saveLocks.mu
|
||||
// before the entry can be observed for deletion, an entry with a pending
|
||||
// acquirer is never deleted.
|
||||
func releaseSaveLock(workloadID string, l *saveLock) {
|
||||
l.mu.Unlock()
|
||||
saveLocks.mu.Lock()
|
||||
l.refs--
|
||||
if l.refs == 0 {
|
||||
delete(saveLocks.locks, workloadID)
|
||||
}
|
||||
saveLocks.mu.Unlock()
|
||||
}
|
||||
|
||||
// saveState upserts the container row, calling mutate so callers can
|
||||
@@ -115,9 +144,8 @@ func lockFor(workloadID string) *sync.Mutex {
|
||||
// Per-workload mutex serializes concurrent callers so two parallel
|
||||
// Deploys can't read the same prior state and race their writes.
|
||||
func saveState(deps plugin.Deps, w plugin.Workload, mutate func(*runtimeState, *store.Container)) error {
|
||||
lk := lockFor(w.ID)
|
||||
lk.Lock()
|
||||
defer lk.Unlock()
|
||||
lk := acquireSaveLock(w.ID)
|
||||
defer releaseSaveLock(w.ID, lk)
|
||||
|
||||
prev, prevRow, err := loadState(deps, w)
|
||||
if err != nil {
|
||||
|
||||
Reference in New Issue
Block a user