fix: comprehensive security, performance, and quality hardening
Security: apply AdminOnly middleware to mutating routes, require ENCRYPTION_KEY and ADMIN_PASSWORD (no insecure defaults), restrict CORS to same-origin, fix OIDC token delivery via cookie instead of URL query param, add rate limiting on login, add MaxBytesReader, validate volume paths against traversal, add security headers, validate user roles, add Secure flag to OIDC cookie. Performance: set SQLite MaxOpenConns(1) to prevent SQLITE_BUSY, add FK indexes on 8 columns, track notifier goroutines with WaitGroup for graceful shutdown, use GetRegistryByName instead of GetAllRegistries in deployer, pass basePath param to avoid redundant settings query, return empty slices from store to remove reflection. Quality: refactor TriggerDeploy to delegate to runDeploy (~100 lines removed), consolidate duplicated utilities (extractPort, boolToInt, now, isTerminalStatus) into shared exports, migrate all log.Printf to slog structured logging, use consistent webhook response envelope, remove dead code (parseEnvVars, duplicate auth types). UX: clean up NPM proxy on instance removal via API, add README with quickstart guide, add .env.example, require ADMIN_PASSWORD in docker-compose, document staging-net prerequisite.
This commit is contained in:
@@ -5,8 +5,9 @@ import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"log"
|
||||
"log/slog"
|
||||
"net/http"
|
||||
"sync"
|
||||
"time"
|
||||
)
|
||||
|
||||
@@ -26,6 +27,7 @@ type Event struct {
|
||||
// Notifications are fire-and-forget — failures are logged but do not propagate.
|
||||
type Notifier struct {
|
||||
httpClient *http.Client
|
||||
wg sync.WaitGroup
|
||||
}
|
||||
|
||||
// New creates a Notifier with sensible defaults.
|
||||
@@ -37,6 +39,11 @@ func New() *Notifier {
|
||||
}
|
||||
}
|
||||
|
||||
// Drain waits for all in-flight notifications to complete.
|
||||
func (n *Notifier) Drain() {
|
||||
n.wg.Wait()
|
||||
}
|
||||
|
||||
// Send sends a notification event to the given webhook URL in a background goroutine.
|
||||
// It does not block the caller. Errors are logged, not returned.
|
||||
func (n *Notifier) Send(webhookURL string, event Event) {
|
||||
@@ -48,9 +55,13 @@ func (n *Notifier) Send(webhookURL string, event Event) {
|
||||
event.Timestamp = time.Now().UTC().Format(time.RFC3339)
|
||||
}
|
||||
|
||||
n.wg.Add(1)
|
||||
go func() {
|
||||
if err := n.doSend(context.Background(), webhookURL, event); err != nil {
|
||||
log.Printf("notify: failed to send webhook to %s: %v", webhookURL, err)
|
||||
defer n.wg.Done()
|
||||
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
|
||||
defer cancel()
|
||||
if err := n.doSend(ctx, webhookURL, event); err != nil {
|
||||
slog.Warn("notify: failed to send webhook", "url", webhookURL, "error", err)
|
||||
}
|
||||
}()
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user