Files
tiny-forge/plans/gitops/phase-4-hardening.md
T
alexei.dolgolyov 7733e64b08 feat(gitops): config-as-code via .tinyforge.yml for repo-backed workloads
A dockerfile or static workload can opt in to reading its deploy config from a
.tinyforge.yml in its own repo. Tinyforge fetches the file, shows field-level
drift vs the live config, and an admin applies it with an explicit Sync. The
repo becomes the source of truth for the declared fields. Manual-sync only;
no auto-apply on deploy, no multi-workload reconcile, no create/delete in v1.

Scope is deliberately source-aware and source_config-resident: dockerfile
declares port/healthcheck/deploy_strategy, static declares deploy_strategy.
The file never carries repo coords or secrets (those stay in the encrypted
DB), which keeps credentials out of the repo.

Backend:
- internal/gitops: Spec/ParseSpec (KnownFields rejects unknown keys), a
  source-aware ApplyPlan/BuildPlan, MergeAndValidate (omitted-field-preserving
  deep merge + validate-the-merged-result-then-commit — never a partial
  config), declared-only Drift with normalization, and Fetch with
  ok/no_file/fetch_failed/invalid statuses and token-redacted messages.
- staticsite: DownloadFile added to GitProvider + Gitea/GitHub/GitLab impls,
  reusing each provider's SSRF-safe client; 64 KiB cap; ErrFileNotFound.
- store: 4 additive gitops_* columns + setters (disjoint from UpdateWorkload
  so the edit-form save and a sync never clobber each other).
- api: GET /workloads/{id}/gitops (status + raw + live drift + managed_fields),
  PUT /gitops (admin, enable/path, traversal-safe), POST /gitops/sync (admin,
  per-workload locked read->merge->validate->write, audited to event_log).

Frontend:
- GitOpsPanel.svelte: status pill, a purpose-built field-level drift view,
  .tinyforge.yml preview, enable ToggleSwitch, Sync via ConfirmDialog; all five
  statuses handled, admin affordances gated on the real viewer role.
- GitOps-managed badge (list + detail hero) and a read-only edit-form banner.
- api.ts fetchers + types; i18n apps.detail.gitops.* (en + ru parity).

Built phase-by-phase with an adversarial plan review (caught 5 design flaws
pre-implementation) and an independent review per phase (go / security / ts /
final) — all APPROVE, 0 CRITICAL/HIGH. docs/gitops.md documents the schema and
what's intentionally out of v1. Plan: plans/gitops/.
2026-06-21 23:32:02 +03:00

1.1 KiB

Phase 4 — Hardening + docs + final review

Tasks

  • Concurrent-sync guard (review S5): per-workload sync mutex (or re-read-then-apply with a compare) so a sync racing the edit-form save / another sync can't silently lose writes.
  • File-size + path hardening: confirm the 64 KiB DownloadFile cap is enforced across all three providers; confirm gitops_path validation rejects traversal.
  • Security-reviewer pass: SSRF (verify the fetch goes through NewGitProvider/the safe client, never raw http.Get), secret handling (token never logged/persisted/leaked in errors — sanitizeError), admin-gating on sync + put.
  • Docs: docs/gitops.md (or extend docs/plans/): the .tinyforge.yml v1 schema reference, how to enable, the sync flow, and an explicit "not in v1" section (env/faces, auto-apply-on-deploy, multi-workload Framing B) with the future seams noted.
  • Final comprehensive review + (if triggered) security review, then present for the merge gate.

Verify

  • Full backend + frontend build/test/vet green; dev server healthy on :8090.

Handoff notes

(filled after implementation)