739b67856a
Build / build (push) Successful in 10m39s
The clean-break delete that closes the workload-first refactor arc.
Net diff: ~30 backend files deleted, ~20 modified, ~12k LOC removed
on the Go side; entire /projects /stacks /sites /deploy frontend
trees gone; ~6.7k LOC removed on the Svelte/TypeScript side.
Backend
- API handlers gone: internal/api/{projects,stages,stage_env,stacks,
static_sites,deploys,instances,volume_browser}.go
- Store CRUD + tests gone: internal/store/{projects,stages,stage_env,
stacks,static_sites,static_site_secrets,deploys,poll_state,volumes,
workload_sync}.go (+ _test.go siblings)
- Legacy deployer pipeline gone: internal/deployer/{bluegreen,promote,
rollback,subdomain,resolver_test}.go; deployer.go trimmed to just the
dispatch surface used by the plugin pipeline
- internal/staticsite/{manager,healthcheck}.go and
internal/stack/manager.go gone (the rest of those packages stay as
helpers imported by the static + compose plugins)
- internal/registry/poller.go gone (legacy registry poller)
- internal/volume.ResolvePath gone; ResolveWorkloadPath stays
- internal/webhook: handleWebhook (project) + handleSiteWebhook (site)
gone; only POST /api/webhook/triggers/{secret} remains
- workload-side webhook URL handlers (getWorkloadWebhook +
regenerateWorkloadWebhook + EnsureWorkloadWebhookSecret +
SetWorkloadWebhookSecret + GetWorkloadByWebhookSecret) gone — they
minted URLs that would 404 against the new trigger-only ingress
- cmd/server/main.go: dropped staticsite.Manager, stack.Manager,
staticsite.HealthChecker, registry poller, SetSiteSyncTriggerer,
SetStaticSiteManager, SetStackManager, wireStaticBackend
- store/store.go: idempotent DROP TABLE IF EXISTS for every legacy
table (projects, stages, stage_env, volumes, deploys, deploy_logs,
poll_states, stacks, stack_revisions, stack_deploys, static_sites,
static_site_secrets); FK order children-then-parents
- store/models.go: dropped Project, Stage, Deploy, DeployLog, StageEnv,
Volume, StaticSite, StaticSiteSecret, Stack, StackRevision,
StackDeploy types; kept WorkloadKind constants as documented strings
- internal/store/helpers.go (new): BoolToInt, rowScanner,
GenerateWebhookSecret extracted from deleted CRUD files
- internal/api/secrets.go (new): forwards to store.GenerateWebhookSecret
so api + store paths share one secret-generation impl (no
panic-vs-UUID-fallback divergence)
- internal/reconciler/reconciler.go: dropped legacy stack-by-compose
+ static-site label paths; only canonical tinyforge.workload.id
dispatch remains
- providers (gitea_content/github_provider/gitlab_provider) gained
path-traversal rejection on every tree entry
- internal/webhook ParsedImage / ParseImageRef demoted to package-
private (no external callers)
Frontend
- /projects /stacks /sites /deploy routes deleted (entire trees)
- ProjectCard / InstanceCard / StaleContainerCard components deleted
- api.ts: dropped every project/stage/stack/site/deploy/instance
helper + types (Project, Stage, Stack, StaticSite, Deploy,
Instance, Volume, etc.); kept Workload, Container, App, Settings,
Registry, EventTrigger, LogScanRule, webhook envelopes
- WorkloadWebhook type + getWorkloadWebhook/regenerateWorkloadWebhook
api functions gone (mirror of the backend deletion above)
- web/src/routes/+layout.svelte: dropped /projects /sites /stacks
/deploy nav entries, trimmed quick-nav keymap
- web/src/routes/+page.svelte: dashboard rewrite — reads
listWorkloads + listContainers only; 4-card stat grid
(workloads/running/failed/stale) + recent workloads strip
- navCounts.ts, SystemHealthCard.svelte, ContainerLogs.svelte,
ContainerStats.svelte, StatusBadge.svelte, TagCombobox.svelte,
proxies/+page.svelte, containers/+page.svelte all rewired to the
workload-first surface
- AbortController plumbing on dashboard, nav-counts, stale page,
SystemHealthCard so navigation doesn't leave dangling fetches
- i18n: dropped projects.*, projectDetail.*, envEditor.*,
volumeEditor.*, volumeBrowser.*, quickDeploy.*, sites.*, stacks.*,
instance.*, confirm.* namespaces; en/ru parity preserved (1042
keys each)
Hardening from go-reviewer + security-reviewer + typescript-reviewer
subagent passes (0 CRITICAL across all three; 1 HIGH + ~12 MEDIUM
addressed inline before commit):
- Sec H1: dead-end workload webhook URL handlers (would mint URLs
that 404 the new trigger-only ingress) deleted across backend +
frontend
- Go M1: IsTerminalDeployStatus dropped (no production callers)
- Go M2: ParsedImage/ParseImageRef lowercased (in-package only)
- Go M6: generateWebhookSecret unified — api shim forwards to
store.GenerateWebhookSecret
- Doc/comment freshness: stage_id (no longer FK), ProxyRoute legacy
field names, workloadIDRow rationale, webhook_deliveries.target_type
enum, WebhookDeliveryLog component header
Doc
- WORKLOAD_REFACTOR_TODO: cutover marked DONE; all three Priority 1
items are now shipped. Next focus is Priority 3 polish (apps.* i18n
+ codemap entries) and Priority 4 tests.
Behavioral notes for operators upgrading from a pre-cutover build
- Existing rows in the dropped tables disappear on first boot.
- Legacy webhook URLs at /api/webhook/{secret} and
/api/webhook/sites/{secret} return 404; CI configs must repoint to
/api/webhook/triggers/{secret} (the trigger-split boot backfill
lifted any embedded workload secret onto a Trigger row, so the
secret value itself carries over).
- Frontend routes /projects /stacks /sites /deploy are gone; nav
links replaced with /apps and /triggers.
107 lines
4.2 KiB
Go
107 lines
4.2 KiB
Go
package api
|
|
|
|
// Outgoing-webhook signing-secret + send-test endpoints. After the hard
|
|
// cutover only the settings tier survives at the API surface; per-workload
|
|
// notification settings live on the workload row itself and are accessed
|
|
// via the workload endpoints.
|
|
|
|
import (
|
|
"context"
|
|
"log/slog"
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/alexei/tinyforge/internal/notify"
|
|
)
|
|
|
|
// notificationSecretResponse is what the GET / regenerate endpoints return.
|
|
// The secret is revealed in cleartext exactly once per request — UI is
|
|
// expected to copy or hash it for display, not store it long-term.
|
|
type notificationSecretResponse struct {
|
|
Secret string `json:"secret"`
|
|
HasSecret bool `json:"has_secret"`
|
|
}
|
|
|
|
// testEventTimeout caps how long we wait for the receiver before declaring
|
|
// the test failed. Mirrors the production notifier's per-request timeout
|
|
// (10s) so test results are predictive of real send behaviour.
|
|
const testEventTimeout = 10 * time.Second
|
|
|
|
// buildTestEvent constructs the synthetic payload used by every "send
|
|
// test" endpoint. Marking it as type "test" prevents a misconfigured
|
|
// receiver from mistaking a wiring check for a real deploy event.
|
|
func buildTestEvent(project, stage string) notify.Event {
|
|
return notify.Event{
|
|
Type: "test",
|
|
Project: project,
|
|
Stage: stage,
|
|
}
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Global / settings tier
|
|
// ---------------------------------------------------------------------------
|
|
|
|
// getSettingsNotificationSecret handles GET /api/settings/notification-secret.
|
|
// Lazily generates a secret if one was never set (typical for sites
|
|
// upgrading from a pre-signing build).
|
|
func (s *Server) getSettingsNotificationSecret(w http.ResponseWriter, r *http.Request) {
|
|
secret, err := s.store.EnsureSettingsNotificationSecret()
|
|
if err != nil {
|
|
slog.Error("get settings notification secret", "error", err)
|
|
respondError(w, http.StatusInternalServerError, "failed to load secret")
|
|
return
|
|
}
|
|
respondJSON(w, http.StatusOK, notificationSecretResponse{Secret: secret, HasSecret: secret != ""})
|
|
}
|
|
|
|
// regenerateSettingsNotificationSecret handles POST
|
|
// /api/settings/notification-secret/regenerate. Replaces the existing
|
|
// secret with a fresh one, invalidating signatures verified against the
|
|
// old secret.
|
|
func (s *Server) regenerateSettingsNotificationSecret(w http.ResponseWriter, r *http.Request) {
|
|
secret := generateWebhookSecret()
|
|
if err := s.store.SetSettingsNotificationSecret(secret); err != nil {
|
|
slog.Error("regenerate settings notification secret", "error", err)
|
|
respondError(w, http.StatusInternalServerError, "failed to rotate secret")
|
|
return
|
|
}
|
|
slog.Info("settings notification secret rotated")
|
|
respondJSON(w, http.StatusOK, notificationSecretResponse{Secret: secret, HasSecret: true})
|
|
}
|
|
|
|
// disableSettingsNotificationSigning handles POST
|
|
// /api/settings/notification-secret/disable. Clears the secret so further
|
|
// outgoing notifications are unsigned. Useful for receivers that don't
|
|
// support HMAC verification.
|
|
func (s *Server) disableSettingsNotificationSigning(w http.ResponseWriter, r *http.Request) {
|
|
if err := s.store.SetSettingsNotificationSecret(""); err != nil {
|
|
slog.Error("disable settings notification signing", "error", err)
|
|
respondError(w, http.StatusInternalServerError, "failed to disable signing")
|
|
return
|
|
}
|
|
respondJSON(w, http.StatusOK, notificationSecretResponse{Secret: "", HasSecret: false})
|
|
}
|
|
|
|
// settingsNotificationTest handles POST /api/settings/notification-test.
|
|
// Sends a synthetic test event to the global webhook URL using the global
|
|
// secret.
|
|
func (s *Server) settingsNotificationTest(w http.ResponseWriter, r *http.Request) {
|
|
settings, err := s.store.GetSettings()
|
|
if err != nil {
|
|
respondError(w, http.StatusInternalServerError, "failed to load settings")
|
|
return
|
|
}
|
|
if settings.NotificationURL == "" {
|
|
respondError(w, http.StatusBadRequest, "no global notification URL configured")
|
|
return
|
|
}
|
|
ctx, cancel := context.WithTimeout(r.Context(), testEventTimeout)
|
|
defer cancel()
|
|
result := s.notifier.SendSyncForTest(
|
|
ctx, settings.NotificationURL, settings.NotificationSecret, notify.TierSettings,
|
|
buildTestEvent("__tinyforge__", ""),
|
|
)
|
|
respondJSON(w, http.StatusOK, result)
|
|
}
|