alexei.dolgolyov
be6ad15efc
Security: apply AdminOnly middleware to mutating routes, require ENCRYPTION_KEY and ADMIN_PASSWORD (no insecure defaults), restrict CORS to same-origin, fix OIDC token delivery via cookie instead of URL query param, add rate limiting on login, add MaxBytesReader, validate volume paths against traversal, add security headers, validate user roles, add Secure flag to OIDC cookie. Performance: set SQLite MaxOpenConns(1) to prevent SQLITE_BUSY, add FK indexes on 8 columns, track notifier goroutines with WaitGroup for graceful shutdown, use GetRegistryByName instead of GetAllRegistries in deployer, pass basePath param to avoid redundant settings query, return empty slices from store to remove reflection. Quality: refactor TriggerDeploy to delegate to runDeploy (~100 lines removed), consolidate duplicated utilities (extractPort, boolToInt, now, isTerminalStatus) into shared exports, migrate all log.Printf to slog structured logging, use consistent webhook response envelope, remove dead code (parseEnvVars, duplicate auth types). UX: clean up NPM proxy on instance removal via API, add README with quickstart guide, add .env.example, require ADMIN_PASSWORD in docker-compose, document staging-net prerequisite.
76 lines
2.1 KiB
Go
76 lines
2.1 KiB
Go
package store
|
|
|
|
import (
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
)
|
|
|
|
// PollState tracks the last polled tag for a stage, enabling the poller to
|
|
// detect new tags since the previous poll cycle.
|
|
type PollState struct {
|
|
StageID string `json:"stage_id"`
|
|
LastTag string `json:"last_tag"`
|
|
LastPolled string `json:"last_polled"`
|
|
}
|
|
|
|
// GetPollState returns the poll state for a given stage.
|
|
func (s *Store) GetPollState(stageID string) (PollState, error) {
|
|
var ps PollState
|
|
err := s.db.QueryRow(
|
|
`SELECT stage_id, last_tag, last_polled FROM poll_states WHERE stage_id = ?`,
|
|
stageID,
|
|
).Scan(&ps.StageID, &ps.LastTag, &ps.LastPolled)
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return PollState{}, fmt.Errorf("poll state for stage %s: %w", stageID, ErrNotFound)
|
|
}
|
|
if err != nil {
|
|
return PollState{}, fmt.Errorf("query poll state: %w", err)
|
|
}
|
|
return ps, nil
|
|
}
|
|
|
|
// UpsertPollState inserts or updates the poll state for a stage.
|
|
func (s *Store) UpsertPollState(ps PollState) error {
|
|
_, err := s.db.Exec(
|
|
`INSERT INTO poll_states (stage_id, last_tag, last_polled)
|
|
VALUES (?, ?, ?)
|
|
ON CONFLICT(stage_id) DO UPDATE SET last_tag=excluded.last_tag, last_polled=excluded.last_polled`,
|
|
ps.StageID, ps.LastTag, ps.LastPolled,
|
|
)
|
|
if err != nil {
|
|
return fmt.Errorf("upsert poll state: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// DeletePollState removes the poll state for a stage.
|
|
func (s *Store) DeletePollState(stageID string) error {
|
|
_, err := s.db.Exec(`DELETE FROM poll_states WHERE stage_id = ?`, stageID)
|
|
if err != nil {
|
|
return fmt.Errorf("delete poll state: %w", err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetAllPollStates returns all poll states, ordered by last_polled descending.
|
|
func (s *Store) GetAllPollStates() ([]PollState, error) {
|
|
rows, err := s.db.Query(
|
|
`SELECT stage_id, last_tag, last_polled FROM poll_states ORDER BY last_polled DESC`,
|
|
)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("query poll states: %w", err)
|
|
}
|
|
defer rows.Close()
|
|
|
|
states := []PollState{}
|
|
for rows.Next() {
|
|
var ps PollState
|
|
if err := rows.Scan(&ps.StageID, &ps.LastTag, &ps.LastPolled); err != nil {
|
|
return nil, fmt.Errorf("scan poll state: %w", err)
|
|
}
|
|
states = append(states, ps)
|
|
}
|
|
return states, rows.Err()
|
|
}
|