a4362b842d
Build / build (push) Successful in 11m42s
Security: - rate limit /api/webhook routes per-IP and cap concurrent site syncs - global SSE connection cap (256) with new sse_gate - validate ?tail= and cap JSON log responses at 4 MiB - strip ANSI/CSI/OSC and control bytes from streamed log lines - redact webhook secret from request log middleware - scrub host details from /api/health for non-admin viewers - drop container_id from /api/system/stats/top for non-admins - generate webhook secrets via crypto/rand; require >=32 chars on insert - verify iid path consistency in streamContainerLogs - LimitReader on site webhook body; reject malformed non-empty bodies Concurrency / correctness: - stats collector: Stop() no longer hangs without Start(), semaphore acquired in parent loop so ctx cancellation short-circuits the queue, in-flight tick cancellable via shared base context, zero-ts guard - webhook handler: replace fire-and-forget goroutine with WaitGroup-tracked workers + Drain() wired into graceful shutdown - $derived(() => ...) mis-idiom fixed in ContainerStats / InstanceCard / ProjectCard (returned function instead of value) - SystemResourcesCard: rename `window` and `t` locals to avoid shadowing globalThis.window and the i18n `t` import Quality / performance: - replace O(n^2) insertion sort with sort.Slice in stats top - runMigrations only swallows duplicate-column / already-exists errors - PruneStatsSamplesBefore wrapped in a transaction - collapse N+1 in unusedImageStats / pruneImages to one ListAllInstances pass; surface DB errors instead of silently treating them as inactive - run Docker Info + DiskUsage in parallel via errgroup - container log SSE emits `: ping` heartbeat every 20 s - imageMatches case-insensitive on registry host (RFC behaviour) - log warning on invalid stage tag pattern instead of silent skip - reject malformed non-empty site webhook payloads Frontend / i18n: - shared formatBytes utility replaces three local copies - statsInterval store drives dynamic "no samples / collection disabled" copy across ContainerStats and SystemResourcesCard - top consumers row now shows owner_name (project/stage or site name) - drop seven `as any` casts on the Settings type; add cloudflare_api_token write-only field - move "Service status", "Docker daemon", "Docker unreachable", "Proxy unreachable", "reachable", and "Docker daemon is not reachable." strings into en/ru i18n bundles
208 lines
6.8 KiB
Go
208 lines
6.8 KiB
Go
package store
|
|
|
|
import (
|
|
"crypto/rand"
|
|
"database/sql"
|
|
"encoding/hex"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/google/uuid"
|
|
)
|
|
|
|
// minWebhookSecretLength is the smallest user-supplied webhook secret accepted
|
|
// at insert time. Auto-generated secrets are 64 hex chars (256 bits); a
|
|
// 32-char floor still leaves > 128 bits of brute-force resistance for hex
|
|
// alphabets and rejects obvious typos / placeholder strings.
|
|
const minWebhookSecretLength = 32
|
|
|
|
// generateWebhookSecret returns a 256-bit hex-encoded random token. We use
|
|
// crypto/rand directly rather than uuid.New() so the intent ("secret token,
|
|
// not identifier") is explicit and the entropy is unambiguous.
|
|
func generateWebhookSecret() string {
|
|
b := make([]byte, 32)
|
|
if _, err := rand.Read(b); err != nil {
|
|
// crypto/rand is documented to never fail on supported platforms;
|
|
// fall back to a UUID rather than panicking.
|
|
return uuid.New().String()
|
|
}
|
|
return hex.EncodeToString(b)
|
|
}
|
|
|
|
// projectCols is the canonical column list for projects queries.
|
|
const projectCols = `id, name, registry, image, port, healthcheck, env, volumes,
|
|
npm_access_list_id, webhook_secret, created_at, updated_at`
|
|
|
|
// CreateProject inserts a new project and returns it. A webhook secret is
|
|
// generated automatically if one is not already set on the input.
|
|
func (s *Store) CreateProject(p Project) (Project, error) {
|
|
p.ID = uuid.New().String()
|
|
p.CreatedAt = Now()
|
|
p.UpdatedAt = p.CreatedAt
|
|
if p.WebhookSecret == "" {
|
|
p.WebhookSecret = generateWebhookSecret()
|
|
} else if len(p.WebhookSecret) < minWebhookSecretLength {
|
|
return Project{}, fmt.Errorf("webhook_secret must be at least %d characters", minWebhookSecretLength)
|
|
}
|
|
|
|
_, err := s.db.Exec(
|
|
`INSERT INTO projects (`+projectCols+`)
|
|
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
|
|
p.ID, p.Name, p.Registry, p.Image, p.Port, p.Healthcheck, p.Env, p.Volumes,
|
|
p.NpmAccessListID, p.WebhookSecret, p.CreatedAt, p.UpdatedAt,
|
|
)
|
|
if err != nil {
|
|
return Project{}, fmt.Errorf("insert project: %w", err)
|
|
}
|
|
return p, nil
|
|
}
|
|
|
|
// GetProjectByID returns a single project by its ID.
|
|
func (s *Store) GetProjectByID(id string) (Project, error) {
|
|
var p Project
|
|
err := s.db.QueryRow(
|
|
`SELECT `+projectCols+` FROM projects WHERE id = ?`, id,
|
|
).Scan(&p.ID, &p.Name, &p.Registry, &p.Image, &p.Port, &p.Healthcheck, &p.Env, &p.Volumes,
|
|
&p.NpmAccessListID, &p.WebhookSecret, &p.CreatedAt, &p.UpdatedAt)
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return Project{}, fmt.Errorf("project %s: %w", id, ErrNotFound)
|
|
}
|
|
if err != nil {
|
|
return Project{}, fmt.Errorf("query project: %w", err)
|
|
}
|
|
return p, nil
|
|
}
|
|
|
|
// GetProjectByWebhookSecret looks up a project by its webhook secret.
|
|
// Returns ErrNotFound if no project has this secret (including empty).
|
|
func (s *Store) GetProjectByWebhookSecret(secret string) (Project, error) {
|
|
if secret == "" {
|
|
return Project{}, ErrNotFound
|
|
}
|
|
var p Project
|
|
err := s.db.QueryRow(
|
|
`SELECT `+projectCols+` FROM projects WHERE webhook_secret = ?`, secret,
|
|
).Scan(&p.ID, &p.Name, &p.Registry, &p.Image, &p.Port, &p.Healthcheck, &p.Env, &p.Volumes,
|
|
&p.NpmAccessListID, &p.WebhookSecret, &p.CreatedAt, &p.UpdatedAt)
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return Project{}, ErrNotFound
|
|
}
|
|
if err != nil {
|
|
return Project{}, fmt.Errorf("query project by webhook secret: %w", err)
|
|
}
|
|
return p, nil
|
|
}
|
|
|
|
// GetAllProjects returns every project ordered by name.
|
|
func (s *Store) GetAllProjects() ([]Project, error) {
|
|
rows, err := s.db.Query(
|
|
`SELECT ` + projectCols + ` FROM projects ORDER BY name`,
|
|
)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("query projects: %w", err)
|
|
}
|
|
defer rows.Close()
|
|
|
|
projects := []Project{}
|
|
for rows.Next() {
|
|
var p Project
|
|
if err := rows.Scan(&p.ID, &p.Name, &p.Registry, &p.Image, &p.Port, &p.Healthcheck, &p.Env, &p.Volumes,
|
|
&p.NpmAccessListID, &p.WebhookSecret, &p.CreatedAt, &p.UpdatedAt); err != nil {
|
|
return nil, fmt.Errorf("scan project: %w", err)
|
|
}
|
|
projects = append(projects, p)
|
|
}
|
|
return projects, rows.Err()
|
|
}
|
|
|
|
// GetProjectsByImage returns all projects using the given image, newest first.
|
|
func (s *Store) GetProjectsByImage(image string) ([]Project, error) {
|
|
rows, err := s.db.Query(
|
|
`SELECT `+projectCols+` FROM projects WHERE image = ? ORDER BY created_at DESC`, image,
|
|
)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("query projects by image: %w", err)
|
|
}
|
|
defer rows.Close()
|
|
|
|
projects := []Project{}
|
|
for rows.Next() {
|
|
var p Project
|
|
if err := rows.Scan(&p.ID, &p.Name, &p.Registry, &p.Image, &p.Port, &p.Healthcheck, &p.Env, &p.Volumes,
|
|
&p.NpmAccessListID, &p.WebhookSecret, &p.CreatedAt, &p.UpdatedAt); err != nil {
|
|
return nil, fmt.Errorf("scan project: %w", err)
|
|
}
|
|
projects = append(projects, p)
|
|
}
|
|
return projects, rows.Err()
|
|
}
|
|
|
|
// UpdateProject updates an existing project's mutable fields. Webhook secret
|
|
// is intentionally not updated here — use SetProjectWebhookSecret instead.
|
|
func (s *Store) UpdateProject(p Project) error {
|
|
p.UpdatedAt = Now()
|
|
result, err := s.db.Exec(
|
|
`UPDATE projects SET name=?, registry=?, image=?, port=?, healthcheck=?, env=?, volumes=?,
|
|
npm_access_list_id=?, updated_at=?
|
|
WHERE id=?`,
|
|
p.Name, p.Registry, p.Image, p.Port, p.Healthcheck, p.Env, p.Volumes,
|
|
p.NpmAccessListID, p.UpdatedAt, p.ID,
|
|
)
|
|
if err != nil {
|
|
return fmt.Errorf("update project: %w", err)
|
|
}
|
|
n, _ := result.RowsAffected()
|
|
if n == 0 {
|
|
return fmt.Errorf("project %s: %w", p.ID, ErrNotFound)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// SetProjectWebhookSecret assigns a webhook secret to a project.
|
|
// Pass an empty string to disable webhook access for the project.
|
|
func (s *Store) SetProjectWebhookSecret(id, secret string) error {
|
|
result, err := s.db.Exec(
|
|
`UPDATE projects SET webhook_secret=?, updated_at=? WHERE id=?`,
|
|
secret, Now(), id,
|
|
)
|
|
if err != nil {
|
|
return fmt.Errorf("set project webhook secret: %w", err)
|
|
}
|
|
n, _ := result.RowsAffected()
|
|
if n == 0 {
|
|
return fmt.Errorf("project %s: %w", id, ErrNotFound)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// EnsureProjectWebhookSecret returns the current webhook secret for a project,
|
|
// generating one on the fly if the stored value is empty (lazy backfill for
|
|
// projects created before the per-project webhook migration).
|
|
func (s *Store) EnsureProjectWebhookSecret(id string) (string, error) {
|
|
project, err := s.GetProjectByID(id)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
if project.WebhookSecret != "" {
|
|
return project.WebhookSecret, nil
|
|
}
|
|
secret := generateWebhookSecret()
|
|
if err := s.SetProjectWebhookSecret(id, secret); err != nil {
|
|
return "", err
|
|
}
|
|
return secret, nil
|
|
}
|
|
|
|
// DeleteProject removes a project by ID. Cascading deletes handle stages, instances, and deploys.
|
|
func (s *Store) DeleteProject(id string) error {
|
|
result, err := s.db.Exec(`DELETE FROM projects WHERE id = ?`, id)
|
|
if err != nil {
|
|
return fmt.Errorf("delete project: %w", err)
|
|
}
|
|
n, _ := result.RowsAffected()
|
|
if n == 0 {
|
|
return fmt.Errorf("project %s: %w", id, ErrNotFound)
|
|
}
|
|
return nil
|
|
}
|