6b45ed62bb
Build / build (push) Successful in 10m59s
Add per-workload capture of host-bind data volumes as downloadable tar.gz archives: a new internal/volsnap engine (enumerate host-bind volumes via the computeMounts merge, archive with archive/tar+gzip skipping symlinks/special files, per-workload retention + startup orphan cleanup), a volume_snapshots table + store CRUD, admin-gated API (list/snapshotable/create/download/delete), and a Snapshots panel on /apps/[id] that shows coverage and which volumes are skipped (and why). Scope: image-source apps, host-bind scopes (absolute/stage/project); Docker named volumes, tmpfs, and instance scope are surfaced as not-yet-supported. Restore is a separate later phase. Download/FilePath are containment-checked; create returns a typed no-data error (400) vs generic 500. Covered by archiver unit tests + full API e2e.
178 lines
5.5 KiB
Go
178 lines
5.5 KiB
Go
package api
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"io"
|
|
"log/slog"
|
|
"net/http"
|
|
"os"
|
|
"path/filepath"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
|
|
"github.com/alexei/tinyforge/internal/store"
|
|
"github.com/alexei/tinyforge/internal/volsnap"
|
|
)
|
|
|
|
// listWorkloadSnapshots handles GET /api/workloads/{id}/snapshots.
|
|
func (s *Server) listWorkloadSnapshots(w http.ResponseWriter, r *http.Request) {
|
|
if s.snapshotEngine == nil {
|
|
respondError(w, http.StatusServiceUnavailable, "snapshot engine not initialized")
|
|
return
|
|
}
|
|
id := chi.URLParam(r, "id")
|
|
snaps, err := s.snapshotEngine.List(id)
|
|
if err != nil {
|
|
slog.Error("snapshots: list", "workload", id, "error", err)
|
|
respondError(w, http.StatusInternalServerError, "internal server error")
|
|
return
|
|
}
|
|
respondJSON(w, http.StatusOK, snaps)
|
|
}
|
|
|
|
// snapshotableVolume is the sanitized view of a volume in the snapshotable
|
|
// response — it omits the resolved host path so internal layout is not leaked.
|
|
type snapshotableVolume struct {
|
|
Target string `json:"target"`
|
|
Scope string `json:"scope"`
|
|
Source string `json:"source"`
|
|
}
|
|
|
|
// getWorkloadSnapshotable handles GET /api/workloads/{id}/snapshotable. It
|
|
// tells the UI which volumes can be snapshotted and which are skipped (and
|
|
// why), so users are never misled about coverage.
|
|
func (s *Server) getWorkloadSnapshotable(w http.ResponseWriter, r *http.Request) {
|
|
if s.snapshotEngine == nil {
|
|
respondError(w, http.StatusServiceUnavailable, "snapshot engine not initialized")
|
|
return
|
|
}
|
|
id := chi.URLParam(r, "id")
|
|
workload, err := s.store.GetWorkloadByID(id)
|
|
if err != nil {
|
|
respondError(w, http.StatusNotFound, "workload not found")
|
|
return
|
|
}
|
|
settings, err := s.store.GetSettings()
|
|
if err != nil {
|
|
respondError(w, http.StatusInternalServerError, "internal server error")
|
|
return
|
|
}
|
|
refs, skipped, err := volsnap.SnapshotableVolumes(s.store, workload, settings)
|
|
if err != nil {
|
|
slog.Error("snapshots: enumerate", "workload", id, "error", err)
|
|
respondError(w, http.StatusInternalServerError, "internal server error")
|
|
return
|
|
}
|
|
|
|
volumes := make([]snapshotableVolume, 0, len(refs))
|
|
for _, ref := range refs {
|
|
volumes = append(volumes, snapshotableVolume{Target: ref.Target, Scope: ref.Scope, Source: ref.Source})
|
|
}
|
|
if skipped == nil {
|
|
skipped = []volsnap.SkippedVolume{}
|
|
}
|
|
respondJSON(w, http.StatusOK, map[string]any{
|
|
"volumes": volumes,
|
|
"skipped": skipped,
|
|
})
|
|
}
|
|
|
|
// createWorkloadSnapshot handles POST /api/workloads/{id}/snapshots.
|
|
func (s *Server) createWorkloadSnapshot(w http.ResponseWriter, r *http.Request) {
|
|
if s.snapshotEngine == nil {
|
|
respondError(w, http.StatusServiceUnavailable, "snapshot engine not initialized")
|
|
return
|
|
}
|
|
id := chi.URLParam(r, "id")
|
|
workload, err := s.store.GetWorkloadByID(id)
|
|
if err != nil {
|
|
respondError(w, http.StatusNotFound, "workload not found")
|
|
return
|
|
}
|
|
settings, err := s.store.GetSettings()
|
|
if err != nil {
|
|
respondError(w, http.StatusInternalServerError, "internal server error")
|
|
return
|
|
}
|
|
|
|
var body struct {
|
|
Label string `json:"label"`
|
|
}
|
|
if r.ContentLength != 0 {
|
|
if err := json.NewDecoder(io.LimitReader(r.Body, 1<<20)).Decode(&body); err != nil && !errors.Is(err, io.EOF) {
|
|
respondError(w, http.StatusBadRequest, "invalid JSON body")
|
|
return
|
|
}
|
|
}
|
|
|
|
snap, err := s.snapshotEngine.Create(workload, settings, body.Label)
|
|
if err != nil {
|
|
// "no snapshottable volume data" is client-actionable (400, safe to
|
|
// echo). Any other error is server-side: log the detail, return a
|
|
// generic 500 so internal paths / DB text never reach the client.
|
|
if errors.Is(err, volsnap.ErrNoSnapshotData) {
|
|
respondError(w, http.StatusBadRequest, err.Error())
|
|
return
|
|
}
|
|
slog.Error("snapshots: create", "workload", id, "error", err)
|
|
respondError(w, http.StatusInternalServerError, "internal server error")
|
|
return
|
|
}
|
|
respondJSON(w, http.StatusCreated, snap)
|
|
}
|
|
|
|
// deleteSnapshot handles DELETE /api/snapshots/{sid}.
|
|
func (s *Server) deleteSnapshot(w http.ResponseWriter, r *http.Request) {
|
|
if s.snapshotEngine == nil {
|
|
respondError(w, http.StatusServiceUnavailable, "snapshot engine not initialized")
|
|
return
|
|
}
|
|
sid := chi.URLParam(r, "sid")
|
|
if err := s.snapshotEngine.Delete(sid); err != nil {
|
|
if errors.Is(err, store.ErrNotFound) {
|
|
respondError(w, http.StatusNotFound, "snapshot not found")
|
|
return
|
|
}
|
|
respondError(w, http.StatusInternalServerError, "failed to delete snapshot")
|
|
return
|
|
}
|
|
respondJSON(w, http.StatusOK, map[string]string{"status": "deleted"})
|
|
}
|
|
|
|
// downloadSnapshot handles GET /api/snapshots/{sid}/download, streaming the
|
|
// tar.gz archive. The resolved path is containment-checked against the
|
|
// snapshot directory.
|
|
func (s *Server) downloadSnapshot(w http.ResponseWriter, r *http.Request) {
|
|
if s.snapshotEngine == nil {
|
|
respondError(w, http.StatusServiceUnavailable, "snapshot engine not initialized")
|
|
return
|
|
}
|
|
sid := chi.URLParam(r, "sid")
|
|
snap, err := s.snapshotEngine.Get(sid)
|
|
if err != nil {
|
|
respondError(w, http.StatusNotFound, "snapshot not found")
|
|
return
|
|
}
|
|
path, err := s.snapshotEngine.FilePath(snap)
|
|
if err != nil {
|
|
respondError(w, http.StatusForbidden, "access denied")
|
|
return
|
|
}
|
|
f, err := os.Open(path)
|
|
if err != nil {
|
|
respondError(w, http.StatusNotFound, "snapshot file not found on disk")
|
|
return
|
|
}
|
|
defer f.Close()
|
|
stat, err := f.Stat()
|
|
if err != nil {
|
|
respondError(w, http.StatusInternalServerError, "failed to read snapshot file")
|
|
return
|
|
}
|
|
name := filepath.Base(snap.Filename)
|
|
w.Header().Set("Content-Type", "application/gzip")
|
|
w.Header().Set("Content-Disposition", "attachment; filename=\""+name+"\"")
|
|
http.ServeContent(w, r, name, stat.ModTime(), f)
|
|
}
|