alexei.dolgolyov
d131ba461c
Lint & Test / test (push) Successful in 20s
Security - Default scripts_management, callbacks_management, links_management, and media_folders_management to False so a leaked token cannot escalate to RCE through admin CRUD endpoints. - TokenSpec + scope hierarchy (read | control | admin); legacy bare-string api_tokens entries promote to admin for back-compat. Management endpoints now require admin scope. - WebSocket subprotocol auth (Sec-WebSocket-Protocol: media-server.token.<T>) preferred over ?token= query so the token no longer lands in URL/history/ Referer; query fallback retained for HA integration back-compat. - Origin allow-list check on the WS endpoint (CSWSH defence). - In-process token-bucket rate limiter: 5/min for failed auths, 10/min for /api/scripts/execute and /api/callbacks/execute. - shell=False subprocess path (shlex.split) + per-parameter regex `pattern` in ScriptParameterConfig to harden shell=true scripts against parameter injection (Windows cmd.exe env-var expansion). - CSP gains form-action, worker-src, manifest-src directives. - Refuse cors_origins=["*"] at startup; strip token=... from uvicorn access logs; validate Gitea release tag against strict SemVer regex. - noopener noreferrer + no-referrer referrerpolicy on every outbound link. - icacls hardening of config.yaml on Windows (current user + SYSTEM + Administrators only); 0600 still enforced on POSIX. - WS volume handler clamps input and never drops the socket on bad messages. Performance - Album-art read in windows_media gated by track key — was decoding the WinRT thumbnail twice per second regardless of track changes. - /api/media/artwork returns content-derived ETag + Cache-Control so the browser sends If-None-Match and gets 304s on track repeats. - Foreground-service ctypes argtypes hoisted to one-time module init (was re-declaring ~14 prototypes per probe). - display_service _static_cache keyed by (edid_hash, ...) tuple with eviction of disappeared monitors — fixes stale capabilities on hot-plug swaps where the new topology has the same monitor count. - Visualizer rAF loop paused on document.hidden, resumed on visible. Reliability / bug fixes - Lifespan rewritten as try/yield/finally so a partial-startup failure cannot orphan background tasks or executors. - _run_callback in routes/media.py keeps a strong task ref (GC-safe) and uses the dedicated callback executor instead of the default pool. - macos_media.set_volume() no longer always returns True. - TrayManager._restart_requested initialised in __init__; set before signalling exit so the main thread observes it correctly. - Missing static_dir now logs a WARNING instead of silent UI disable. UX / accessibility / PWA - manifest.json theme_color and background_color match the Studio Reference base (#0E0D0B); added id and scope for PWA installability. - ARIA on mini-player icon buttons; inner SVGs marked aria-hidden. - OS mediaSession API wired so headset / lockscreen / Bluetooth buttons drive play/pause/next/prev/seek and show track metadata + artwork. Observability - X-Request-ID middleware (accept upstream id if it matches a safe regex, otherwise UUID4); request_id_var added to ContextVars and included in every log line alongside the token label. - Audit log (append-only JSONL) for every script + callback execution, including the on_play/on_pause/etc. event callbacks. Background-thread writer; queue capped; flushed in lifespan teardown. Deployment - proxy_headers + forwarded_allow_ips plumbed through Settings → uvicorn.Config for reverse-proxy installs. - HTTPS support via ssl_certfile + ssl_keyfile (+ optional password); startup refuses to launch with only one of the pair set. - Thumbnail cache moved from project-root .cache to %LOCALAPPDATA%/media-server/cache (Windows) and $XDG_CACHE_HOME/media-server/thumbnails (POSIX). Tests - 35 new tests across auth scopes, rate limiter, browser path traversal (../ NUL UNC absolute), script-param validation incl. regex, Gitea tag whitelist, config atomic write + POSIX perms. 47 passed / 4 skipped.
84 lines
2.3 KiB
Python
84 lines
2.3 KiB
Python
"""Smoke tests for the foreground tracker.
|
|
|
|
The OS-specific probe code is hard to mock end-to-end inside a CI container,
|
|
so these tests focus on the platform-agnostic surface: the dataclass shape,
|
|
TTL caching, and graceful fallback when the platform probe raises. The
|
|
Windows/Linux/macOS probes themselves are exercised through manual runs.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from media_server.services import foreground_service as fg
|
|
|
|
|
|
def setup_function(_):
|
|
fg.reset_cache()
|
|
|
|
|
|
def test_unavailable_default_shape():
|
|
info = fg.ForegroundInfo(available=False)
|
|
d = info.to_dict()
|
|
assert d["available"] is False
|
|
assert d["pid"] is None
|
|
assert d["process_name"] is None
|
|
assert d["is_fullscreen"] is False
|
|
assert "platform" in d
|
|
|
|
|
|
def test_cache_returns_same_instance(monkeypatch):
|
|
calls = {"n": 0}
|
|
|
|
def fake_probe():
|
|
calls["n"] += 1
|
|
return fg.ForegroundInfo(available=True, pid=42, process_name="x.exe")
|
|
|
|
monkeypatch.setattr(fg, "_probe", fake_probe)
|
|
|
|
a = fg.get_foreground_info()
|
|
b = fg.get_foreground_info()
|
|
assert a is b
|
|
assert calls["n"] == 1
|
|
|
|
|
|
def test_cache_force_refresh(monkeypatch):
|
|
calls = {"n": 0}
|
|
|
|
def fake_probe():
|
|
calls["n"] += 1
|
|
return fg.ForegroundInfo(available=True, pid=calls["n"])
|
|
|
|
monkeypatch.setattr(fg, "_probe", fake_probe)
|
|
|
|
fg.get_foreground_info()
|
|
fg.get_foreground_info(force_refresh=True)
|
|
assert calls["n"] == 2
|
|
|
|
|
|
def test_cache_ttl_expiry(monkeypatch):
|
|
calls = {"n": 0}
|
|
|
|
def fake_probe():
|
|
calls["n"] += 1
|
|
return fg.ForegroundInfo(available=True, pid=calls["n"])
|
|
|
|
monkeypatch.setattr(fg, "_probe", fake_probe)
|
|
monkeypatch.setattr(fg, "_CACHE_TTL", 0.0)
|
|
# Re-bind the cache's TTL by exercising it twice with TTL 0.
|
|
fg.get_foreground_info()
|
|
fg.get_foreground_info()
|
|
assert calls["n"] == 2
|
|
|
|
|
|
def test_probe_crash_returns_unavailable(monkeypatch):
|
|
def boom():
|
|
raise RuntimeError("kaboom")
|
|
|
|
# Force every platform branch to call our crashing probe.
|
|
monkeypatch.setattr(fg, "_probe_windows", boom)
|
|
monkeypatch.setattr(fg, "_probe_linux", boom)
|
|
monkeypatch.setattr(fg, "_probe_macos", boom)
|
|
|
|
info = fg._probe()
|
|
assert info.available is False
|
|
assert info.error and "kaboom" in info.error
|