Files

T

Build / build (push) Successful in 10m36s

Details

chore(workload): close the workload-first arc — apps i18n + codemap + tests

Closes the workload-first refactor by landing the Priority 3 polish
items and the Priority 4 test gap. Net: ~2,400 lines added,
~350 lines modified across 13 files.

Priority 3 — polish
- apps.* i18n namespace: 276 new keys across apps.list.* (27),
  apps.new.* (91, sibling of existing apps.new.triggers.*), and
  apps.detail.* (158, sibling of existing apps.detail.bindings.*).
  EN+RU at 1314 keys each, perfectly in sync. /apps, /apps/new,
  /apps/[id] now render entirely from i18n.
- New codemap docs/CODEMAPS/workload-plugin.md (238 lines):
  Source × Trigger contract, dispatch seam, webhook fan-out path,
  recipes for adding a new Source or Trigger kind. Plus
  docs/CODEMAPS/INDEX.md gateway.

Priority 4 — tests
- internal/api/workloads_test.go (new, ~30 subtests): /api/workloads
  CRUD + deploy + delete + env + volumes + chain + promote-from +
  triggers list/inline-bind + auth gating + standalone /api/triggers
  CRUD (create / dup-409 / kind filter / delete). Uses real
  POST handlers via httptest.NewServer + a fake plugin source
  registered under "testfakesource".
- internal/deployer/dispatch_test.go (new, 11 tests):
  DispatchPlugin / DispatchTeardown / DispatchReconcile happy +
  unknown-kind + propagated-error each; PluginDeps wiring; a real
  2s-bounded RWMutex deadlock probe on PluginDeps vs SetDNSProvider.
- internal/workload/plugin/source/compose/compose_test.go (new,
  ~26 subtests): composeProjectName sanitization,
  writeYAML / writeYAMLIfChanged hash short-circuit, Validate happy
  + bad inputs, Kind / SchemaSample.

Coverage delta on the workload-plugin path:
- internal/api: 1.1% → 16.0%
- internal/deployer: 0% → 54.1%
- internal/workload/plugin/source/compose: 0% → 38.5%
- Trigger plugins already at 87-95% from the trigger-split work.

Production fix surfaced by the tests
- store.CreateWorkload now self-references RefID = ID when caller
  leaves RefID empty (the typical plugin-native path). The api
  layer's broken backfill loop (called UpdateWorkload, which
  deliberately omits ref_id) is gone. Multiple sibling plugin
  workloads can now coexist under the UNIQUE(kind, ref_id) constraint.

Review fixes addressed before commit
- CRITICAL: deadlock-detect test gained a real 2s time.After (was
  selecting on context.Background().Done() which never fires).
- HIGH: happy-path test now hard-asserts RefID = ID (was a t.Logf
  that would silently pass after a production fix).
- HIGH: standalone /api/triggers CRUD coverage added (was bypassed
  by the workload-side bind flow).
- HIGH: seedWorkload bypass deleted; tests now go through the
  real POST /api/workloads handler.
- MEDIUM: withTempDir restore is a no-op (t.Setenv auto-restores);
  dead `old := os.Getenv(...)` capture removed.
- MEDIUM: list-workloads test now asserts ID membership, not just
  count.

Doc
- WORKLOAD_REFACTOR_TODO: all three Priority 1 items, Priority 3
  polish, and Priority 4 tests marked DONE. The workload-first arc
  is closed.

2026-05-16 06:42:43 +03:00

2.4 KiB

Raw Blame History

Tinyforge Codemaps — Index

Last Updated: 2026-05-16

This directory contains architectural maps of key Tinyforge subsystems. Each codemap focuses on one major area: core data types, contract surfaces, integration points, and recipes for extending the system.

Codemaps

Area	File	Focus
Workload Plugin	`workload-plugin.md`	Source × Trigger plugin contracts; registry lookups; webhook fan-out; how to add new kinds

Cross-References

Workload Refactor Handoff — docs/WORKLOAD_REFACTOR_TODO.md — Full status of the trigger-split, legacy cutover, and remaining Priority items
Webhook Documentation — docs/webhooks.md — Outgoing webhook events, signature scheme, receiver code samples
Observability + Event Triggers — docs/LOGSCAN_AND_TRIGGERS_TODO.md — Log scanning rules, event triggers, related infrastructure

How to Use These Codemaps

Starting a new feature in an existing area? Read the relevant codemap first to understand the contract surface and integration seams.
Adding a new plugin kind (Source or Trigger)? See the recipes in workload-plugin.md — "How to Add a New Source Kind" / "How to Add a New Trigger Kind".
Debugging a plugin dispatch failure (deploy, webhook, reconcile)? The "Data Flow" and "Integration Points" sections map out each path end-to-end.
Reviewing someone else's plugin PR? Check the contracts (Source.Deploy(), Trigger.Match(), etc.) against the descriptions here.

Coverage

These codemaps are automatically generated from the codebase structure. If a key file or area is missing, it indicates:

The area is under active refactor (see WORKLOAD_REFACTOR_TODO.md for priority order)
The area is legacy code scheduled for deprecation
The area is simple enough to document inline (JSDoc + comments in the source)

Freshness

Codemaps are updated whenever:

A new plugin kind is added
The contract surface changes (new Source/Trigger method, new Deps field, etc.)
Integration points shift (new API endpoint, new reconciler behavior, etc.)
A major refactor lands (see workload-refactor status for examples)

When you land a change that affects these areas, please update the relevant codemap and the Last Updated timestamp.

2.4 KiB Raw Blame History Unescape Escape